[Math] Fix template Fitter::SetFCN and FitFCN #10737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for the changes introduced in a previous commit (see PR root-project#10650) that avoids the cloininc of FCN. When the FCN is provided as a Funcotr class or a Lambda an internal wrapper object is created in the templated Fitter::SetFCN method that needs to be cloned in order to have it not deleted after exiting SetFCN.
The tutorial has been moved to use the Fitter class instead of the old legacy TVirtualFitter. The tutorial uses the template Fitter::SetFCN funciton.
|
Starting build on |
guitargeek
approved these changes
Jun 10, 2022
|
Build failed on mac11/cxx17. Failing tests: |
|
The cloning happens only for the internal created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request fixes the handling of the FCN function provided when using the template
signature of SetFCN and FitFCN.
This PR fixes #10732