Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test timeout #10886

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Increase test timeout #10886

merged 1 commit into from
Nov 13, 2023

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Jul 3, 2022

This Pull request:

Increase some test timeouts

Changes or fixes:

Fixes occasional test timeout failures. Mostly seen on aarch64.

The following tests FAILED:
	330 - TMVA-DNN-MethodDL-Adam-Optimization-Cpu (Timeout)
	967 - tutorial-tmva-TMVAMulticlass (Timeout)

The timeout has been seen for various tutorial-tmva-TMVA* tests, not just the one mentions above.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ellert ellert requested a review from bellenot as a code owner July 3, 2022 06:30
@ellert
Copy link
Contributor Author

ellert commented Nov 17, 2022

PR updated to also address

346 - gtest-tree-tree-test-testBulkApiMultiple (Timeout)

@bellenot bellenot assigned bellenot and unassigned lmoneta Nov 17, 2022
@ellert
Copy link
Contributor Author

ellert commented Dec 13, 2022

Now passes all the tests.

@root-project root-project deleted a comment from phsft-bot Nov 13, 2023
@root-project root-project deleted a comment from phsft-bot Nov 13, 2023
@root-project root-project deleted a comment from phsft-bot Nov 13, 2023
@root-project root-project deleted a comment from phsft-bot Nov 13, 2023
@root-project root-project deleted a comment from phsft-bot Nov 13, 2023
@root-project root-project deleted a comment from phsft-bot Nov 13, 2023
@root-project root-project deleted a comment from phsft-bot Nov 13, 2023
@guitargeek
Copy link
Contributor

guitargeek commented Nov 13, 2023 •
edited

@phsft-bot build

Let's see if the tests are still passing and then merge the PR, which @bellenot already approved.

I like the idea of making the timeout configurable 👍

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@guitargeek guitargeek merged commit a1bdb59 into root-project:master Nov 13, 2023
1 check passed
@ellert ellert deleted the test-timeout branch November 17, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellenot bellenot bellenot approved these changes

Assignees

@bellenot bellenot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ellert @guitargeek @phsft-bot @bellenot @lmoneta