[GSOC][TMVA][SOFIE] Pow ONNX Operator added to SOFIE with the corresponding unit tests. #10971

Neel-Shah-29 · 2022-07-15T16:40:45Z

This Pull request: Pow ONNX Operator implemented with the corresponding unit tests to validate the written code.

Checklist:

tested changes locally

phsft-bot · 2022-07-15T16:40:48Z

Can one of the admins verify this patch?

lmoneta · 2022-07-19T15:52:21Z

@phsft-bot build just on ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On

phsft-bot · 2022-07-19T15:52:26Z

Starting build on ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On
How to customize builds

phsft-bot · 2022-07-19T16:15:18Z

Build failed on ROOT-ubuntu2004/default.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-07-19T16:15:17.160Z] FAILED: lib/modules.idx

lmoneta · 2022-07-22T12:24:01Z

tmva/sofie/inc/TMVA/ROperator_Pow.hxx

+      size_t length = ConvertShapeToLength(fShape);
+      out << "\n//------ POW\n";
+      out << SP << "for (int id = 0; id < " << length << " ; id++){\n";
+      out << SP << SP << "tensor_" << fNY << "[id] = std::pow(tensor_" << fNX1 << "[id] , tensor_" << fNX2 << "[id]);\n";


I think there is a problem in the broadcasting case, when the two tensor shapes are not the same. We compute correctly the shape but we need also to have a new intermediate tensor which has the same shape as fNX1 and is the broadcasted result of fNX2 and we use that one for the pow function.

lmoneta · 2022-07-22T14:41:33Z

Hi @Neel-Shah-29 ,
I see there is also a conflict after I have merged the other PR's. Can you please fix it ?
Thank you !

lmoneta · 2022-07-22T20:46:50Z

@phsft-bot build just on ROOT-ubuntu2204/default, ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On

phsft-bot · 2022-07-22T20:46:56Z

Starting build on ROOT-ubuntu2204/default, ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On
How to customize builds

phsft-bot · 2022-07-22T20:54:59Z

Build failed on ROOT-ubuntu2004/default.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-07-22T20:54:47.855Z] FAILED: tmva/sofie/test/CMakeFiles/SofieCompileModels_ROOT.util

phsft-bot · 2022-07-22T21:04:58Z

Build failed on ROOT-ubuntu2204/default.
Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

lmoneta

I think it would be better to integrate this operator in the BinaryOperator types, so we will have less code. Thank you @Neel-Shah-29 if you can do this

lmoneta · 2022-08-17T13:33:17Z

@phsft-bot build just on ROOT-ubuntu2204/default, ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On

phsft-bot · 2022-08-17T13:33:25Z

Starting build on ROOT-ubuntu2204/default, ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On
How to customize builds

phsft-bot · 2022-08-17T13:33:43Z

Build failed on ROOT-ubuntu2204/default.
Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-08-17T13:33:42.356Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1088 (message):

phsft-bot · 2022-08-17T13:33:59Z

Build failed on ROOT-ubuntu2004/default.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-08-17T13:33:58.564Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1088 (message):

phsft-bot · 2022-08-17T13:34:36Z

Build failed on ROOT-ubuntu18.04/default.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-08-17T13:34:35.553Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1088 (message):

lmoneta · 2022-08-18T12:53:58Z

@phsft-bot build just on ROOT-ubuntu2204/default, ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On

phsft-bot · 2022-08-18T12:54:05Z

Starting build on ROOT-ubuntu2204/default, ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On
How to customize builds

phsft-bot · 2022-08-18T12:54:53Z

Build failed on ROOT-ubuntu2204/default.
Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-08-18T12:54:52.753Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1088 (message):

phsft-bot · 2022-08-18T12:54:56Z

Build failed on ROOT-ubuntu2004/default.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-08-18T12:54:55.127Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1088 (message):

phsft-bot · 2022-08-18T12:56:12Z

Build failed on ROOT-ubuntu18.04/default.
Running on sft-ubuntu-1804-3.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-08-18T12:56:11.464Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1088 (message):

… the code.

…educe the code

lmoneta · 2022-08-19T08:46:07Z

@phsft-bot build just on ROOT-ubuntu2204/default, ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On

phsft-bot · 2022-08-19T08:46:14Z

Starting build on ROOT-ubuntu2204/default, ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On
How to customize builds

phsft-bot · 2022-08-19T09:11:17Z

Build failed on ROOT-ubuntu2204/default.
Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2022-08-19T08:57:51.579Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
[2022-08-19T08:57:53.823Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
[2022-08-19T08:58:05.001Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
[2022-08-19T08:58:05.258Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]

Failing tests:

lmoneta

LGTM ! Thank you Neel for applying the suggested changes !

Neel-Shah-29 requested review from bellenot, lmoneta and sitongan as code owners July 15, 2022 16:40

guitargeek added the in:TMVA label Jul 18, 2022

guitargeek assigned lmoneta Jul 18, 2022

lmoneta reviewed Jul 22, 2022

View reviewed changes

Neel-Shah-29 force-pushed the Neel-Shah-Pow branch from 1808e4b to 5a08169 Compare July 22, 2022 19:06

Neel-Shah-29 requested a review from lmoneta July 22, 2022 19:10

lmoneta reviewed Aug 16, 2022

View reviewed changes

Neel-Shah-29 requested review from lmoneta and removed request for bellenot and sitongan August 18, 2022 11:51

Neel-Shah-29 added 3 commits August 18, 2022 22:15

Pow ONNX Operator added with the corresponding unit tests to validate…

7136cf9

… the code.

Pow ONNX Operator implemented as one of the Binary Operator enum to r…

febe9c5

…educe the code

Fixed the merge conflicts related to Pow Operator

7fc6639

Neel-Shah-29 force-pushed the Neel-Shah-Pow branch from 9425295 to 7fc6639 Compare August 18, 2022 18:32

lmoneta approved these changes Aug 19, 2022

View reviewed changes

lmoneta merged commit 452f821 into root-project:master Aug 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GSOC][TMVA][SOFIE] Pow ONNX Operator added to SOFIE with the corresponding unit tests. #10971

[GSOC][TMVA][SOFIE] Pow ONNX Operator added to SOFIE with the corresponding unit tests. #10971

Neel-Shah-29 commented Jul 15, 2022

phsft-bot commented Jul 15, 2022

lmoneta commented Jul 19, 2022

phsft-bot commented Jul 19, 2022

phsft-bot commented Jul 19, 2022

lmoneta Jul 22, 2022

lmoneta commented Jul 22, 2022

lmoneta commented Jul 22, 2022

phsft-bot commented Jul 22, 2022

phsft-bot commented Jul 22, 2022

phsft-bot commented Jul 22, 2022

lmoneta left a comment

lmoneta commented Aug 17, 2022

phsft-bot commented Aug 17, 2022

phsft-bot commented Aug 17, 2022

phsft-bot commented Aug 17, 2022

phsft-bot commented Aug 17, 2022

lmoneta commented Aug 18, 2022

phsft-bot commented Aug 18, 2022

phsft-bot commented Aug 18, 2022

phsft-bot commented Aug 18, 2022

phsft-bot commented Aug 18, 2022

lmoneta commented Aug 19, 2022

phsft-bot commented Aug 19, 2022

phsft-bot commented Aug 19, 2022

lmoneta left a comment

[GSOC][TMVA][SOFIE] Pow ONNX Operator added to SOFIE with the corresponding unit tests. #10971

[GSOC][TMVA][SOFIE] Pow ONNX Operator added to SOFIE with the corresponding unit tests. #10971

Conversation

Neel-Shah-29 commented Jul 15, 2022

This Pull request: Pow ONNX Operator implemented with the corresponding unit tests to validate the written code.

Checklist:

phsft-bot commented Jul 15, 2022

lmoneta commented Jul 19, 2022

phsft-bot commented Jul 19, 2022

phsft-bot commented Jul 19, 2022

Errors:

lmoneta Jul 22, 2022

Choose a reason for hiding this comment

lmoneta commented Jul 22, 2022

lmoneta commented Jul 22, 2022

phsft-bot commented Jul 22, 2022

phsft-bot commented Jul 22, 2022

Errors:

phsft-bot commented Jul 22, 2022

Failing tests:

lmoneta left a comment

Choose a reason for hiding this comment

lmoneta commented Aug 17, 2022

phsft-bot commented Aug 17, 2022

phsft-bot commented Aug 17, 2022

Errors:

phsft-bot commented Aug 17, 2022

Errors:

phsft-bot commented Aug 17, 2022

Errors:

lmoneta commented Aug 18, 2022

phsft-bot commented Aug 18, 2022

phsft-bot commented Aug 18, 2022

Errors:

phsft-bot commented Aug 18, 2022

Errors:

phsft-bot commented Aug 18, 2022

Errors:

lmoneta commented Aug 19, 2022

phsft-bot commented Aug 19, 2022

phsft-bot commented Aug 19, 2022

Warnings:

Failing tests:

lmoneta left a comment

Choose a reason for hiding this comment