Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GSOC][TMVA][SOFIE] Reduce ONNX Operators implemented with the corresponding unit tests #11258

Merged
merged 8 commits into from Aug 31, 2022
Merged

[GSOC][TMVA][SOFIE] Reduce ONNX Operators implemented with the corresponding unit tests #11258

merged 8 commits into from Aug 31, 2022

Conversation

Neel-Shah-29
Copy link
Contributor

This Pull request: Adds the ReduceMean, ReduceProd and ReduceSumsquare operators in SOFIE

Checklist:

  • tested changes locally

@phsft-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@lmoneta
Copy link
Member

lmoneta commented Aug 29, 2022

@phsft-bot build just on ROOT-ubuntu2204/default, ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-ubuntu2204/default, ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/default.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-08-29T10:56:25.362Z] FAILED: tmva/sofie/test/CMakeFiles/SofieCompileModels_ROOT.util

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu18.04/default.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-08-29T10:58:09.357Z] FAILED: tmva/sofie/test/CMakeFiles/SofieCompileModels_ONNX.util

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2204/default.
Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

  • [2022-08-29T10:57:58.313Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
  • [2022-08-29T10:57:59.252Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Reduce.hxx:119:31: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits]
  • [2022-08-29T10:57:59.252Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Reduce.hxx:119:31: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits]
  • [2022-08-29T10:57:59.252Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Reduce.hxx:119:31: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits]
  • [2022-08-29T10:58:00.451Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Reduce.hxx:119:31: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits]
  • [2022-08-29T10:58:00.451Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Reduce.hxx:119:31: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits]
  • [2022-08-29T10:58:00.451Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tmva/sofie/inc/TMVA/ROperator_Reduce.hxx:119:31: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits]
  • [2022-08-29T10:58:00.451Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
  • [2022-08-29T10:58:06.633Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
  • [2022-08-29T10:58:09.922Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]

And 3 more

lmoneta
lmoneta reviewed Aug 30, 2022
View reviewed changes
tmva/sofie/inc/TMVA/ROperator_Reduce.hxx Outdated Show resolved Hide resolved
tmva/sofie/inc/TMVA/ROperator_Reduce.hxx Outdated Show resolved Hide resolved
@Neel-Shah-29 Neel-Shah-29 requested review from lmoneta and removed request for bellenot and sitongan August 30, 2022 14:22
@lmoneta
Copy link
Member

lmoneta commented Aug 30, 2022

@phsft-bot build just on ROOT-ubuntu2204/default, ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-ubuntu2204/default, ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/default.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-08-30T16:18:49.560Z] FAILED: lib/modules.idx

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2204/default.
Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

  • [2022-08-30T16:14:42.325Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
  • [2022-08-30T16:14:46.698Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
  • [2022-08-30T16:14:57.776Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
  • [2022-08-30T16:14:58.037Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu18.04/default.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@lmoneta
Copy link
Member

lmoneta commented Aug 31, 2022

@phsft-bot build just on ROOT-ubuntu2204/default, ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-ubuntu2204/default, ROOT-ubuntu2004/default, ROOT-ubuntu18.04/default with flags -Dtmva-sofie=On
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2204/default.
Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

  • [2022-08-31T08:32:29.912Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
  • [2022-08-31T08:32:32.118Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
  • [2022-08-31T08:32:35.677Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]
  • [2022-08-31T08:32:39.967Z] /usr/include/python3.10/numpy/__multiarray_api.h:1464:1: warning: ‘int _import_array()’ defined but not used [-Wunused-function]

Failing tests:

lmoneta
lmoneta approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@lmoneta lmoneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Neel for addressing my comments.
The PR looks good now, all the TMVA SOFIE tests pass.

@lmoneta lmoneta merged commit 137c7ad into root-project:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoneta lmoneta lmoneta approved these changes

Assignees

@lmoneta lmoneta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Neel-Shah-29 @phsft-bot @lmoneta