[PyROOT][10454] Prevent memory hogging issue when checking for enums #11412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axel-Naumann
approved these changes
Sep 22, 2022
As reported in issue root-project#10454, calling ClassInfo_IsEnum() repeatedly increases the memory consumption of the program. This does not happen with TEnum::GetEnum, which can be used instead.
Test Results 10 files 10 suites 1d 21h 52m 58s ⏱️ For more details on these failures, see this check. Results for commit d38ffc5. ♻️ This comment has been updated with latest results. |
|
@vepadulano Can you check why this seemingly straightforward change is making some test fail? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in issue #10454, calling
ClassInfo_IsEnum()repeatedly increases the memory consumption of the program. This does not happen withTEnum::GetEnum(), which can be used instead.