Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful no DistRDF #12407

Merged
merged 2 commits into from Mar 2, 2023
Merged

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Mar 2, 2023

This Pull request:

Missing experimental add-on module ROOT.RDF.Experimental.Distributed (DistRDF) should not fail the loading of the rest of the ROOT.RDF namespace.

Also addresses a mismatch in the minimum Python version check in the code vs. cmake.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2173518

The minimum version was changed in bindings/CMakeLists.txt but not in
the check in the code.
(DistRDF) should not fail the loading of the rest of the ROOT.RDF
namespace.
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ellert ! Although I'm curious about what scenario reproduced your error. AFAIK given a ROOT build with Python 3.8, RDataFrame and PyROOT active, the DistRDF module is always available. Maybe the error was triggered by the wrong if sys.version_info >= (3, 7) in your build? I saw your comments on the linked bug report, all clear, thanks again for catching this!

@ellert
Copy link
Contributor Author

ellert commented Mar 2, 2023

This is an RPM packaged root. It is split into several packages in order to be flexible so that users can install the parts they need. So someone who installs the pyroot package does not necessarily install also the distrdf package, so it can be missing in their user installation. They should still be able to use the non-distrdf part of ROOT.RDF namespace.

@vepadulano vepadulano merged commit 3301e69 into root-project:master Mar 2, 2023
@ellert ellert deleted the graceful-no-distrdf branch March 3, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants