Fix an issue with the canvas editor when the canvas is embedded #12477

bellenot · 2023-03-10T23:06:03Z

Fix a problem with the editor not appearing when the TCanvas is embedded, as reported on the Forum

Fix a problem with the editor not appearing when the TCanvas is embedded, [as reported on the Forum](https://root-forum.cern.ch/t/editor-not-appearing-in-gui-canvas/53968)

phsft-bot · 2023-03-10T23:06:10Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-03-10T23:08:59Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-03-10T23:11:23Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-03-10T23:13:37Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-03-10T23:17:18Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-03-10T23:20:07Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-03-10T23:47:10Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2023-03-10T23:27:54.185Z] /home/sftnight/build/workspace/root-pullrequests-build/root/gui/gui/src/TRootCanvas.cxx:1476:44: warning: declaration of ‘Bool_t show’ shadows a parameter [-Wshadow]

phsft-bot · 2023-03-10T23:47:19Z

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2023-03-10T23:24:13.834Z] /mnt/build/workspace/root-pullrequests-build/root/gui/gui/src/TRootCanvas.cxx:1476:44: warning: declaration of ‘Bool_t show’ shadows a parameter [-Wshadow]

phsft-bot · 2023-03-10T23:51:06Z

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Warnings:

[2023-03-10T23:33:05.060Z] /data/sftnight/workspace/root-pullrequests-build/root/gui/gui/src/TRootCanvas.cxx:1476:44: warning: declaration of ‘Bool_t show’ shadows a parameter [-Wshadow]

phsft-bot · 2023-03-10T23:53:03Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2023-03-10T23:25:20.105Z] /home/sftnight/build/workspace/root-pullrequests-build/root/gui/gui/src/TRootCanvas.cxx:1476:44: warning: declaration of ‘Bool_t show’ shadows a parameter [-Wshadow]

Fix `TRootCanvas.cxx:1476:44: warning: declaration of �Bool_t show� shadows a parameter [-Wshadow]`

phsft-bot · 2023-03-10T23:58:55Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-03-11T00:31:05Z

Build failed on mac12/noimt.
Running on macphsft17.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roofit.hs3.test.gtest_roofit_hs3_test_testHS3SimultaneousFit

github-actions · 2023-03-11T00:59:19Z

Test Results

      2 files       2 suites 14h 27m 27s ⏱️
2 415 tests 2 404 ✔️ 2 💤   9 ❌
4 832 runs 4 813 ✔️ 8 💤 11 ❌

For more details on these failures, see this check.

Results for commit eed1fab.

♻️ This comment has been updated with latest results.

bellenot · 2023-03-11T10:52:15Z

@phsft-bot build

phsft-bot · 2023-03-11T10:52:21Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-03-11T11:21:36Z

Build failed on mac12/noimt.
Running on macphsft17.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roofit.hs3.test.gtest_roofit_hs3_test_testHS3SimultaneousFit

phsft-bot · 2023-03-11T12:15:18Z

Build failed on mac11/cxx14.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roofit.hs3.test.gtest_roofit_hs3_test_testHS3SimultaneousFit

Axel-Naumann · 2023-03-14T13:28:16Z

gui/gui/src/TRootCanvas.cxx

@@ -1473,6 +1473,35 @@ void TRootCanvas::ShowEditor(Bool_t show)
   UInt_t h = GetHeight();
   UInt_t s = fHorizontal1->GetHeight();

+   auto lambda_show = [&, this](Bool_t display) {


The parameter is always == show, right? So why pass it as a parameter at all? Why not use it from the lambda?

Oh yes, you're right...

gui/gui/src/TRootCanvas.cxx

Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch>

phsft-bot · 2023-03-14T13:33:08Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-03-14T13:59:59Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

…-project#12477) * Fix an issue with the canvas editor when the canvas is embedded Fix a problem with the editor not appearing when the TCanvas is embedded, [as reported on the Forum](https://root-forum.cern.ch/t/editor-not-appearing-in-gui-canvas/53968) Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch> * Cosmetics (thanks Axel!) --------- Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch> (cherry picked from commit 77d0a99)

* Fix an issue with the canvas editor when the canvas is embedded Fix a problem with the editor not appearing when the TCanvas is embedded, [as reported on the Forum](https://root-forum.cern.ch/t/editor-not-appearing-in-gui-canvas/53968) Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch> * Cosmetics (thanks Axel!) --------- Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch> (cherry picked from commit 77d0a99)

…-project#12477) * Fix an issue with the canvas editor when the canvas is embedded Fix a problem with the editor not appearing when the TCanvas is embedded, [as reported on the Forum](https://root-forum.cern.ch/t/editor-not-appearing-in-gui-canvas/53968) Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch> * Cosmetics (thanks Axel!) --------- Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch>

Fix an issue with the canvas editor when the canvas is embedded

4c230d9

Fix a problem with the editor not appearing when the TCanvas is embedded, [as reported on the Forum](https://root-forum.cern.ch/t/editor-not-appearing-in-gui-canvas/53968)

bellenot requested review from Axel-Naumann and couet March 10, 2023 23:06

bellenot self-assigned this Mar 10, 2023

clang-format

1501d37

cosmetics

273e4fc

cosmetics - again

d1ddd62

clang format (it should report all at once...)

0761d9e

fix clang format - again

f7f9304

Fix a compilation warning

99439ac

Fix `TRootCanvas.cxx:1476:44: warning: declaration of �Bool_t show� shadows a parameter [-Wshadow]`

Axel-Naumann approved these changes Mar 14, 2023

View reviewed changes

Update gui/gui/src/TRootCanvas.cxx

a6f6f66

Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch>

Cosmetics (thanks Axel!)

eed1fab

bellenot merged commit 77d0a99 into root-project:master Mar 15, 2023
6 of 8 checks passed

bellenot deleted the fix-embedded-canvas-editor branch March 15, 2023 07:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix an issue with the canvas editor when the canvas is embedded #12477

Fix an issue with the canvas editor when the canvas is embedded #12477

bellenot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 11, 2023

github-actions bot commented Mar 11, 2023 •

edited

bellenot commented Mar 11, 2023

phsft-bot commented Mar 11, 2023

phsft-bot commented Mar 11, 2023

phsft-bot commented Mar 11, 2023

Axel-Naumann Mar 14, 2023

bellenot Mar 14, 2023

phsft-bot commented Mar 14, 2023

phsft-bot commented Mar 14, 2023

Fix an issue with the canvas editor when the canvas is embedded #12477

Fix an issue with the canvas editor when the canvas is embedded #12477

Conversation

bellenot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 10, 2023

Warnings:

phsft-bot commented Mar 10, 2023

Warnings:

phsft-bot commented Mar 10, 2023

Warnings:

phsft-bot commented Mar 10, 2023

Warnings:

phsft-bot commented Mar 10, 2023

phsft-bot commented Mar 11, 2023

Failing tests:

github-actions bot commented Mar 11, 2023 • edited

Test Results

bellenot commented Mar 11, 2023

phsft-bot commented Mar 11, 2023

phsft-bot commented Mar 11, 2023

Failing tests:

phsft-bot commented Mar 11, 2023

Failing tests:

Axel-Naumann Mar 14, 2023

Choose a reason for hiding this comment

bellenot Mar 14, 2023

Choose a reason for hiding this comment

phsft-bot commented Mar 14, 2023

phsft-bot commented Mar 14, 2023

github-actions bot commented Mar 11, 2023 •

edited