Fix for TF1::SetRangerUser

[couet]

Fix #12679

When drawiing 2 TF1 with different ranges the 2nd one (drawn iwth SAME) was not correct.

Reproducer:

{
   auto C = new TCanvas();
   auto f1 = new TF1("f1","1 + 0.5*cos(30*x)",2.5,4);
   f1->SetNpx(250);
   f1->GetXaxis()->SetRangeUser(3,3.5);
   f1->SetMarkerStyle(20);
   f1->SetMarkerColor(2);

   auto f2 = new TF1("f2","1 + 0.5*cos(30*x)",2.5,4);
   f2->SetNpx(250);
   f2->GetXaxis()->SetRangeUser(3.3,3.4);
   f2->SetLineColor(4);
   f2->SetLineWidth(4);

   f1->Draw(" p");
   f2->Draw("same  L");
   C->SetGridx();
}

[phsft-bot]

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

[phsft-bot]

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.test.test_stressgraphics_interpreted

[phsft-bot]

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.test.test_stressgraphics
• projectroot.test.test_stressgraphics_interpreted

[phsft-bot]

Build failed on mac12/noimt.
Running on macphsft17.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.test.test_stressgraphics_interpreted

[phsft-bot]

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.test.test_stressgraphics_interpreted

[phsft-bot]

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.test.test_stressgraphics_interpreted

[github-actions]

Test Results

         5 files           5 suites   1d 4h 32m 21s ⏱️
  2 427 tests   2 421 ✔️ 0 💤   6 ❌
11 976 runs  11 955 ✔️ 0 💤 21 ❌

For more details on these failures, see this check.

Results for commit a5f93af.

♻️ This comment has been updated with latest results.

[phsft-bot]

Build failed on mac11/cxx14.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.test.test_stressgraphics
• projectroot.test.test_stressgraphics_interpreted

[lmoneta]

LGTM!
Thank you Olivier for the fix. I understand what was causing this problem.
Do you know why these two lines were there ? Maybe worth looking at the history if in case those lines were added to fix a particular issue

if (xmin < pmin) xmin = pmin;
 if (xmax > pmax) xmax = pmax;

In principle if you want to make the histogram in a smaller range, one should also scale the number of bins of the histograms to be consistent.

[couet]

Hi Lorenzo. I did look at the history and it seems to have been always there. There is no test or code illustrating why they have been ut there. I will do more check and merge. Thanks.

[phsft-bot]

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

[phsft-bot]

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.test.test_stressgraphics_interpreted

[phsft-bot]

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.test.test_stressgraphics_interpreted

[phsft-bot]

Build failed on mac12/noimt.
Running on macphsft17.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.bindings.experimental.distrdf.test.pyunittests_distrdf_unit_test_operation
• projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_rdataframe_makenumpy
• projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_rdataframe_histo_profile
• projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_rtensor

[phsft-bot]

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

[phsft-bot]

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.test.test_stressgraphics
• projectroot.test.test_stressgraphics_interpreted

[phsft-bot]

Build failed on mac11/cxx14.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.runtutorials.tutorial_dataframe_df010_trivialDataSource_py
• projectroot.runtutorials.tutorial_dataframe_distrdf001_spark_connection_py
• projectroot.runtutorials.tutorial_dataframe_distrdf002_dask_connection_py
• projectroot.runtutorials.tutorial_tmva_TMVA_Higgs_Classification_py
• projectroot.bindings.experimental.distrdf.test.pyunittests_distrdf_unit_test_operation
• projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_rdataframe_makenumpy
• projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_rdataframe_histo_profile
• projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_rtensor