Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement options for Honeycomb #13343

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Implement options for Honeycomb #13343

merged 2 commits into from
Aug 1, 2023

Conversation

couet
Copy link
Member

@couet couet commented Jul 28, 2023

New parameter option for Honeycomb.

  • If the option "v" is specified, the hexagons are drawn "vertically" (default).
  • If the option "h" is selected they are drawn "horizontally".

The option "h" has been suggested by Sam Liechty in this forum thread:

https://root-forum.cern.ch/t/rotate-a-figure-90-degrees/55623/7

Thanks Sam !

@couet couet requested a review from lmoneta as a code owner July 28, 2023 10:03
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14
How to customize builds

@couet couet requested a review from linev July 28, 2023 10:03
@root-project root-project deleted a comment from sonatype-lift bot Jul 28, 2023
@github-actions
Copy link

github-actions bot commented Jul 28, 2023 •
edited

Test Results

         9 files           9 suites   2d 1h 51m 54s ⏱️
  2 475 tests   2 475 ✔️ 0 💤 0 ❌
21 174 runs  21 174 ✔️ 0 💤 0 ❌

Results for commit c99183e.

♻️ This comment has been updated with latest results.

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

bellenot
bellenot approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@couet couet merged commit 896937e into root-project:master Aug 1, 2023
13 of 15 checks passed
@couet couet deleted the honeycomb branch September 28, 2023 09:13
maksgraczyk pushed a commit to maksgraczyk/root that referenced this pull request Jan 12, 2024
@couet @maksgraczyk
Implement options for Honeycomb (root-project#13343)
4a236c0 
* Implement options for Honeycomb

* code formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellenot bellenot bellenot approved these changes

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

@linev linev Awaiting requested review from linev

Assignees

@couet couet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@couet @phsft-bot @bellenot