[RF] Fix pserv.C and pclient.C tutorials
#13357
Conversation
Use the same default parameters for send and recieve functions as also used in the non-parallel sockets, such that `kDefault` doesn't need to be passed explicitly. Also, change return type of `TPServerSocket::Accept()` to `TPSocket*`, which is covariant with the return typoe `TSocket*` expected by the virtual funciton `TServerSocket::Accept()`.
The `TSocket::IsValid()` method is virtual, just like the `Send()` method. But if the base class `TSocket::Send()` method is used in the overriding classes (like TPSocket), then the validity check needs to be the original one of the `TSocket`, and not dispatched virtually.
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
Starting build on |
guitargeek
changed the title
pserv.C and pclientC tutorialspserv.C and pclient.C tutorials
There was a problem hiding this comment.
Thanks, @guitargeek
We should mark TPSocket* as legacy interfaces. @couet could you submit a follow-up PR that marks this as legacy and says "please use one of the many network libraries instead, such as Boost Asio"?
|
Build failed on ROOT-debian10-i386/soversion. |
Some minor fixes to make the
pserv.Candpclient.Ctutorials work again.