[NFC][DF] Improvements to docs #13385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vepadulano
approved these changes
Aug 3, 2023
| "myFriend.MyCol" in the example above). | ||
| "myFriend.MyCol" in the example above if there is no column "MyCol" in the main tree). | ||
|
|
||
| \note A common source of confusion is that trees that are written out from a multi-thread Snapshot() call will have their |
There was a problem hiding this comment.
Maybe a warning could be better in this case since it's a source of confusion, we want people to see this paragraph as easily as possible
There was a problem hiding this comment.
notes are quite visible and a warning seems to harsh to me: this is a clarification on a concept, not a "don't use this" or "you are probably doing something wrong" kind of thing
There is no constructor that accepts more than one tree at the same time. Co-authored-by: Vincenzo Eduardo Padulano <v.e.padulano@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.