Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow geometry transparency at the volume level #13402

Merged

Conversation

MarkusFrankATcernch
Copy link
Contributor

This Pull request:

This Pull request allows to set in TGeo the transparency of objects at the level of individual TGeoVolume instances.

ROOT was attributing the volume transparency to the material of the volume.
This is not always the desired behavior. The PR preserves the current functionality if the transparency level is not
explicitly set to the volume instance.
Improved functionality: If the transparency level is set directly to the volume instance, the volume transparency
takes precedence over the material transparency. The default behavior can be restored by setting a transparency
level of -1 to the volume.

Changes or fixes:

Improves the flexibility to set transparency to geometry volumes.

Checklist:

  • [xxx] tested changes locally
  • updated the docs (if necessary)

This PR fixes #

@phsft-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Member

@agheata agheata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Markus, we need to preserve backward compatibility, see my comment

geom/geom/inc/TGeoVolume.h Outdated Show resolved Hide resolved
geom/geom/inc/TGeoVolume.h Outdated Show resolved Hide resolved
Co-authored-by: Andrei Gheata <andrei.gheata@cern.ch>
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Test Results

         8 files           8 suites   2d 6h 33m 34s ⏱️
  2 475 tests   2 468 ✔️ 0 💤   7
18 846 runs  18 834 ✔️ 0 💤 12

For more details on these failures, see this check.

Results for commit 0898708.

@agheata
Copy link
Member

agheata commented Aug 8, 2023

Failing tests are unrelated

@agheata agheata merged commit 0ebca95 into root-project:master Aug 8, 2023
7 of 12 checks passed
maksgraczyk pushed a commit to maksgraczyk/root that referenced this pull request Jan 12, 2024
* Allow geometry transparency at the volume level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants