Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rounding problem in circle drawing in latex parser #13425

Merged
merged 1 commit into from Aug 14, 2023
Merged

Fix rounding problem in circle drawing in latex parser #13425

merged 1 commit into from Aug 14, 2023

Conversation

linev
Copy link
Member

@linev linev commented Aug 9, 2023

Used only for #odot processing

Fixes: https://root-forum.cern.ch/t/55967

@linev linev requested a review from couet as a code owner August 9, 2023 13:00
@linev linev self-assigned this Aug 9, 2023
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

@github-actions
Copy link

Test Results

         8 files           8 suites   1d 14h 44m 8s ⏱️
  2 475 tests   2 473 ✔️ 0 💤 2 ❌
18 829 runs  18 827 ✔️ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit ff5aed5.

couet
couet approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@couet couet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linev linev merged commit 6276954 into root-project:master Aug 14, 2023
7 of 13 checks passed
@linev linev deleted the latex_odot branch August 14, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@couet couet couet approved these changes

Assignees

@linev linev

Labels
affects:master in:Graphics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@linev @phsft-bot @couet