Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TNetXNGFile::Close() reentrant #13559

Merged
merged 1 commit into from Aug 29, 2023
Merged

Conversation

linev
Copy link
Member

@linev linev commented Aug 29, 2023

Check if fFile pointer still available

Fixes #13503

Check if fFile pointer still available
@linev linev self-assigned this Aug 29, 2023
@linev linev requested a review from gganis as a code owner August 29, 2023 08:41
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link
Collaborator

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on mac11/noimt.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@github-actions
Copy link

Test Results

       10 files         10 suites   2d 6h 25m 18s ⏱️
  2 481 tests      495 ✔️   0 💤 1 986
23 753 runs  21 456 ✔️ 81 💤 2 216

For more details on these failures, see this check.

Results for commit 6c18c77.

@linev linev merged commit 54154f7 into root-project:master Aug 29, 2023
7 of 14 checks passed
@linev linev deleted the nextng_close branch August 29, 2023 11:48
@vepadulano
Copy link
Member

@linev could you also add a test along the lines of #13503 please?

@linev
Copy link
Member Author

linev commented Aug 29, 2023

@vepadulano Do we have xrootd server permanently running with test file?

@vepadulano
Copy link
Member

Sure, you can choose any file from

[root_src]$: grep -r "root://eospublic.cern.ch/"

@linev
Copy link
Member Author

linev commented Aug 29, 2023

@vepadulano Can you approve #13562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double call to TNetXNGFile::Close() leads to a segfault
4 participants