Mention root.cern instead of root.cern.ch #14275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
requested review from
bellenot,
linev,
eguiraud,
vepadulano,
couet,
pcanal,
lmoneta,
sitongan,
hageboeck,
gganis and
Axel-Naumann
as code owners
|
Starting build on |
guitargeek
force-pushed
the
root.cern-src
branch
from
37c1339
to
ed9366f
Compare
|
Starting build on |
Nice, thanks!! Maybe it's even worth to add the check in the CI tests as already done in the web: https://github.com/root-project/web/blob/d1b74175cdcbb5d43a86c8de9293439396d07fe9/.github/workflows/continuous-integration-workflow.yml#L40 |
|
Thanks! That's a great idea for another PR 😄 |
dpiparo
requested review from
dpiparo
and removed request for
Axel-Naumann,
gganis,
linev,
pcanal,
lmoneta,
bellenot,
sitongan,
eguiraud and
vepadulano
This was referenced Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of this PR, which already got approved: