[TMVA] Move tmva/tmva/inc/TMVA/DNN/Architectures/Cpu/Blas.h to src
#14330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Blas.h` header is only used by the tmva-cpu implementation, so it should be made private by moving it to `src`. The problem with having it in `inc` was that this header included GSL, and therefore GSL appeared to be a public dependency of TMVA, which is not true. Closes root-project#14263.
|
Starting build on |
ferdymercury
approved these changes
Jan 11, 2024
Test Results 9 files 9 suites 1d 22h 7m 9s ⏱️ Results for commit 2ef68d7. ♻️ This comment has been updated with latest results. |
|
Should this be backported to 6.30 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Blas.hheader is only used by the tmva-cpu implementation, so it should be made private by moving it tosrc.The problem with having it in
incwas that this header included GSL, and therefore GSL appeared to be a public dependency of TMVA, which is not true.Closes #14263.