Fixed tutorial. Added explicit dependency of shared library on ROOT dictionary #14619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 task
Test Results 10 files 10 suites 1d 19h 16m 24s ⏱️ Results for commit 1d5e5c2. |
vepadulano
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Thanks a lot @atolosadelgado ! Tested offline on MacOS 14 and this works! Although I fear we might have bigger problems with the CMake Xcode generator, but it's out of scope for this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
tutorial/tree/dictionary C++ stand-alone application can not be compiled when the cmake project is generated for xcode. The solution is to explicitly tell cmake that the shared library depends on the ROOT dictionary
Changes or fixes:
New line in the CMakeLists specifying the dependency
Checklist:
This PR fixes #14595