Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core/zip+lzma] Properly account for header size [v6.30] #14624

Merged
merged 4 commits into from
Feb 8, 2024
Merged

[core/zip+lzma] Properly account for header size [v6.30] #14624

merged 4 commits into from
Feb 8, 2024

Commits on Feb 8, 2024

  1. [core/zip] Properly account for HDRSIZE in R__zipZLIB 

    R__unzipZLIB is already properly subtracting it from srcsize.

(cherry picked from commit 44d1c23)
    @hahnjo
    hahnjo committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    beb1b23 View commit details
    Browse the repository at this point in the history

  2. [core/lzma] Properly account for kHeaderSize 

    lzma_code must only see the buffers without the header, so the sizes
have to be adjusted accordingly.

Fixes root-project#14508

(cherry picked from commit 17e3561)
    @hahnjo
    hahnjo committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    04e6935 View commit details
    Browse the repository at this point in the history

  3. [core/zip] Validate target size before compression 

    In practice, the target size is greater or equal the source size in most
cases for ROOT, but add this additional correct check to fuzz the inputs
in the next commit.

(cherry picked from commit 23261a6)
    @hahnjo
    hahnjo committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a8cad67 View commit details
    Browse the repository at this point in the history

  4. [core/zip] Add test for compression buffer sizes 

    This would have found any of the previous three commits.

(cherry picked from commit 73d8c3d)
    @hahnjo
    hahnjo committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    29d1a76 View commit details
    Browse the repository at this point in the history