Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core/zip+lzma] Properly account for header size [v6.28] #14625

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Feb 8, 2024

The compression algorithms only see the buffers without the header, so the sizes have to be adjusted accordingly.

Fixes #14508, backport of #14523

R__unzipZLIB is already properly subtracting it from srcsize.

(cherry picked from commit 44d1c23)
lzma_code must only see the buffers without the header, so the sizes
have to be adjusted accordingly.

Fixes root-project#14508

(cherry picked from commit 17e3561)
In practice, the target size is greater or equal the source size in most
cases for ROOT, but add this additional correct check to fuzz the inputs
in the next commit.

(cherry picked from commit 23261a6)
This would have found any of the previous three commits.

(cherry picked from commit 73d8c3d)
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@hahnjo hahnjo merged commit a8d678e into root-project:v6-28-00-patches Feb 8, 2024
1 of 2 checks passed
@hahnjo hahnjo deleted the core-zip-v628 branch February 8, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants