Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the computation of the Confidence band of TRatioPlot #14840

Merged
merged 2 commits into from Feb 28, 2024
Merged

Fix the computation of the Confidence band of TRatioPlot #14840

merged 2 commits into from Feb 28, 2024

Conversation

lmoneta
Copy link
Member

@lmoneta lmoneta commented Feb 27, 2024

The wrong index was used when filling the TGraphError for the lower plot. TGraph starts from 0 while histogram binning from 1.

Fix also retrieving the fitted function from the histogram

This PR fixes #14838

@lmoneta lmoneta requested a review from couet as a code owner February 27, 2024 15:02
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@lmoneta lmoneta self-assigned this Feb 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2024 •
edited

Test Results

    11 files      11 suites   2d 11h 14m 6s ⏱️
 2 596 tests  2 587 ✅ 0 💤  9 ❌
26 967 runs  26 956 ✅ 0 💤 11 ❌

For more details on these failures, see this check.

Results for commit 052ff17.

♻️ This comment has been updated with latest results.

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@lmoneta
Fix the computation of the Confidence band of TRatioPlot
f8ab9b7 
The wrong index was used when filling the TGraphError for the lower plot.
TGraph starts from 0 while histogram binning from 1.

Fix also retrieving the fitted function from the histogram

Implement fix thanks to FerdyMercury
@lmoneta
[tmva][sofie] Fix a compilation warning in SOFIE
052ff17
@lmoneta lmoneta force-pushed the fix_tratioplot_confidenceband branch from 644b00b to 052ff17 Compare February 28, 2024 08:19
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@lmoneta lmoneta merged commit 46594e2 into root-project:master Feb 28, 2024
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferdymercury ferdymercury ferdymercury left review comments

@couet couet couet approved these changes

Assignees

@lmoneta lmoneta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with Confidence Band of TRatioPlot
4 participants
@lmoneta @phsft-bot @couet @ferdymercury