Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Silence TGFileDialog error messages #14865

Merged
merged 1 commit into from Mar 1, 2024

Conversation

bellenot
Copy link
Member

@bellenot bellenot commented Mar 1, 2024

Silence "Can't read file attributes" with protected system files on Windows.
This addresses the following topic on the Forum:
TGFileDialog multiple "Can't read file attributes" errors on Windows

Silence "Can't read file attributes" with protected system files on Windows
Address the following topic on the Forum:
[TGFileDialog multiple "Can't read file attributes" errors on Windows](https://root-forum.cern.ch/t/tgfiledialog-multiple-cant-read-file-attributes-errors-on-windows/58342)
@bellenot bellenot requested a review from dpiparo March 1, 2024 09:52
@bellenot bellenot self-assigned this Mar 1, 2024
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

Copy link

github-actions bot commented Mar 1, 2024

Test Results

    12 files      12 suites   2d 4h 58m 1s ⏱️
 2 595 tests  2 595 ✅ 0 💤 0 ❌
29 140 runs  29 140 ✅ 0 💤 0 ❌

Results for commit 99cc14b.

@vepadulano
Copy link
Member

Since the errors are true and valid, shouldn't we keep them? Or make them more clear as in `you are trying to access a system-protected file" or something similar?

@bellenot
Copy link
Member Author

bellenot commented Mar 1, 2024

Since the errors are true and valid, shouldn't we keep them? Or make them more clear as in `you are trying to access a system-protected file" or something similar?

The user complains about the error message, then I'm not sure changing the text of the message will help in this case. And the error is ENOENT, meaning the file doesn't exists, which is not necessarily true, so telling this is a system protected file is not even reflecting the reality on all OSes

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see the reasoning, thanks!

@bellenot bellenot merged commit 1fa4a5c into root-project:master Mar 1, 2024
17 checks passed
@bellenot bellenot deleted the silence-fs-errors branch March 1, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants