Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print instructive error message if builtin_llvm=off #1509

Merged
merged 1 commit into from Jan 15, 2018

Conversation

wiene
Copy link
Contributor

@wiene wiene commented Jan 12, 2018

Fixes bug ROOT-9186.

@wiene wiene requested a review from amadio as a code owner January 12, 2018 23:02
@phsft-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@Axel-Naumann
Copy link
Member

Thanks, @wiene ! Indeed - we have upstreamed llvm patches but not yet all of those on clang.

@phsft-bot build!

@Axel-Naumann
Copy link
Member

@phsft-bot build!

@phsft-bot
Copy link
Collaborator

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on centos7/gcc49.
See console output.

@wiene
Copy link
Contributor Author

wiene commented Jan 15, 2018

@Axel-Naumann, looking at the build logs, it seems to me that there is a problem with the CI system: "No space left on device". Could you have a look at it?

@Axel-Naumann
Copy link
Member

Yes we're aware and working on a fix.

@Axel-Naumann Axel-Naumann merged commit cf22dd0 into root-project:master Jan 15, 2018
@vgvassilev
Copy link
Member

LLVM is technically patch free. We can teach our build system to try to find LLVM 5.0 and use it. The tricky part is that we still need to build clang (we should probably set the LLVM_EXTERNAL_CLANG_SOURCE_DIR).

@Axel-Naumann
Copy link
Member

Indeed, but that should happen through a different PR; the current state is best described and fixed by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants