[TMath] Add Gradient and Laplacian methods for arrays #15100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
ferdymercury
reviewed
Apr 2, 2024
ferdymercury
reviewed
Apr 2, 2024
ferdymercury
reviewed
Apr 2, 2024
ferdymercury
reviewed
Apr 2, 2024
ferdymercury
requested changes
Apr 13, 2024
ferdymercury
requested changes
Apr 13, 2024
Thanks! From my side, the only thing left is improving the documentation of Laplacian, try copy-pasting from Gradient and adapting. |
pitkajuh
force-pushed
the
fix-14304
branch
2 times, most recently
from
c4a28aa
to
689204e
Compare
Thank you for providing suggestions and taking your time to review the code. |
ferdymercury
requested changes
Apr 14, 2024
Done. |
ferdymercury
approved these changes
Apr 14, 2024
Test Results 11 files 11 suites 2d 5h 31m 22s ⏱️ Results for commit 047635f. ♻️ This comment has been updated with latest results. |
ferdymercury
approved these changes
Apr 17, 2024
pitkajuh
requested review from
guitargeek,
dpiparo and
vepadulano
as code owners
ferdymercury
requested changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Dear All. This pull request adds gradient and Laplacian methods for arrays. These can be used to calculate one-dimensional first and second order derivatives. Should there also be methods for calculating higher order derivatives and dimensions?
I am open to any feedback regarding the code.
Checklist:
This PR fixes #14304