[CMake] Fix ordering problem when checking and setting cuda flag
#15155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the ROOT build system, `CheckCompiler` is included before `RootBuildOptions`. The problem with this is that when building with `-Dall=ON`, the `cuda` flag is only set in `RootBuildOptions`, which is too late to find the CUDA compiler in `CheckCompiler`. This results in issues like root-project#15139: ``` CMake Error in roofit/batchcompute/CMakeLists.txt: Exporting the target "RooBatchCompute_CUDA" is not allowed since its linker language cannot be determined ``` This commit suggests a solution to this problem: just always enable the CUDA language in CMake if it is found, and only set the `cuda` flag with `-Dall=ON` if the CUDA language is enabled.
bellenot
approved these changes
Apr 5, 2024
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ROOT build system,
CheckCompileris included beforeRootBuildOptions. The problem with this is that when building with-Dall=ON, thecudaflag is only set inRootBuildOptions, which is too late to find the CUDA compiler inCheckCompiler. This results in issues like #15139:This commit suggests a solution to this problem: just always enable the CUDA language in CMake if it is found, and only set the
cudaflag with-Dall=ONif the CUDA language is enabled.