[v632] Backport yesterday's fixes #15190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROOT requires C++17 anyway, so this is redundant and can be confusing.
* remove wrong multiplication of type size in `CastPersistentToShared` * restructure `InitializeTensor` to only provide read-only accessors * avoid memory leak of persistified data when reading back from file * reset `fSize` member in `CastSharedToPersistent` to avoid wrong size info when persistifying the same model twice (otherwise, the multiplication with the element size in bytes would happen twice, resulting in overruns when copying the transient data) Extends on root-project#15162.
* Apply rule of five * Use correct `ClassDef` macro only when necessary * Remove relationship to `TObject` from `RModel_Base` * Properly implement virtual hierarchy for `RModel_GNNBase` and derived
The `bool` columns in RDF are special, because the Take action returns a `std::vector<bool>`, which has an implementation-depended memory layout for space optimization. Therefore, I suggest supporting taking `bool` columns as `unsigned char` with `Take()`, such that in `RDataFrameAsNumpy` the values can be directly taken as bytes. This avoids superfluous copying in the code, and keeps the special logic in the pythonization side minimal. Closes root-project#8639.
This should be added so we can test RBDT in the CI.
* avoid warnings with opened file that is not closed
* don't assume the number of features is in the `_features_count`
attribute (that one doesn't exist with xgboost 2.0)
* support the `"reg:squarederror"` target, which is the default
regression target in xgboost 2.0
Disabled because RBDT doesn't support the imbalanced tree structure of XGBoost models.
XGBoost has to be imported before ROOT to avoid crashes because of clashing std::regexp symbols that are exported by cppyy. See also: wlav/cppyy#227
guitargeek
requested review from
bellenot,
martamaja10,
vepadulano,
couet,
lmoneta and
dpiparo
as code owners
guitargeek
merged commit f0a585c
into
root-project:v6-32-00-patches
6 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_package(Python3)#15168boolcolumns to NumPy arrays #15180xgboostandscikit-learnto requirements #15183