[cmake] fine-tune the builtin-afterimage flag removal #15195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fine-tunes commit root-project@0992621
And clarify warning, rather than saying that it is not supported, as someone might think that things that are now ON by default are no longer supported.
Test Results 12 files 12 suites 2d 5h 11m 6s ⏱️ Results for commit c9fceaa. ♻️ This comment has been updated with latest results. |
bellenot
approved these changes
Apr 10, 2024
ferdymercury
changed the title
|
Thanks! Please backport to 6.32. [EDIT: Nope, it will not be backported. It was just deprecated in 6.32] |
vepadulano
pushed a commit
to vepadulano/root
that referenced
this pull request
Apr 11, 2024
…5195) * [cmake] only build afterimage if asimage is ON Fine-tunes commit root-project@0992621 * [cmake] mention builtin_afterimage as removed And clarify warning, rather than saying that it is not supported, as someone might think that things that are now ON by default are no longer supported.
kristupaspranc
pushed a commit
to kristupaspranc/root
that referenced
this pull request
May 21, 2024
…5195) * [cmake] only build afterimage if asimage is ON Fine-tunes commit root-project@0992621 * [cmake] mention builtin_afterimage as removed And clarify warning, rather than saying that it is not supported, as someone might think that things that are now ON by default are no longer supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Minor changes after builtin_afterimage removal