Distributed RDataFrame: add support for NodeProxy.GetColumnNames #15476
Conversation
|
@gwmyers sorry for the late reply and thank you so much for this contribution 😄 ! I agree with the implementation, I took the liberty of modifying locally your changes also including a test. I would like to push them to your branch to update this PR if you are okay with it, let me know 👍 . |
|
Hi @vepadulano , excellent! Thanks! Please feel free to push your updates to my branch. |
vepadulano
force-pushed
the
rdf-distributed-getcolnames
branch
from
20b1024
to
cd64faf
Compare
Propagate the booking of transformations to the internal RDataFrame object stored in the headnode and expose the `GetColumnNames` method through the proxy interface.
vepadulano
force-pushed
the
rdf-distributed-getcolnames
branch
from
cd64faf
to
826446f
Compare
Test Results 12 files 12 suites 2d 19h 33m 12s ⏱️ For more details on these failures, see this check. Results for commit 826446f. |
|
A few more changes were needed, also touching a couple of tests in roottest, so I opened another PR to follow up this one. Let's see what the CI has to say over there 👍 |
|
The linked PR was merged, closing this PR now. @gwmyers thanks again for kickstarting this fix :D! |
This Pull request:
Update the distributed RDataFrame to use the HeadNode _localrdf to keep track of transform operations, and add the ability to call GetColumnNames on a NodeProxy object.
Changes or fixes:
Checklist:
This PR fixes #15442