Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cxxmodules] Enable 17 tests and exclude 2 tests #2040

Merged
merged 4 commits into from
May 22, 2018
Merged

[cxxmodules] Enable 17 tests and exclude 2 tests #2040

merged 4 commits into from
May 22, 2018

Conversation

yamaguchi1024
Copy link
Contributor

@yamaguchi1024 yamaguchi1024 commented May 18, 2018 •
edited

Recent change to master fixed some tests which were excluded previously, so I reverted "excluding tests" patches and excluded three tests which were failing in current master.

@phsft-bot
Copy link
Collaborator

Starting build on slc6/clang39, slc6/gcc48, slc6/gcc48, slc6/gcc49, slc6/gcc52, centos7/gcc62, centos7/gcc7, centos7/gcc7, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@yamaguchi1024
Copy link
Contributor Author

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

@phsft-bot
Copy link
Collaborator

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on slc6/gcc62.
See console output.

@yamaguchi1024
Copy link
Contributor Author

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on slc6/clang39, slc6/gcc48, slc6/gcc48, slc6/gcc49, slc6/gcc52, centos7/gcc62, centos7/gcc7, centos7/gcc7, ubuntu16/native, mac1013/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@yamaguchi1024
Copy link
Contributor Author

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

@phsft-bot
Copy link
Collaborator

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on slc6/gcc62.
See console output.

Errors:

  • /usr/include/stdlib.h:785:8: error: reference to 'div_t' is ambiguous
  • /usr/include/stdlib.h:785:14: error: functions that differ only in their return type cannot be overloaded
  • /usr/include/stdlib.h:787:8: error: reference to 'ldiv_t' is ambiguous
  • /usr/include/stdlib.h:787:15: error: functions that differ only in their return type cannot be overloaded
  • /usr/include/stdlib.h:793:22: error: reference to 'lldiv_t' is ambiguous
  • /usr/include/stdlib.h:793:30: error: functions that differ only in their return type cannot be overloaded
  • /cvmfs/sft.cern.ch/lcg/contrib/gcc/6.2.0native/x86_64-slc6/bin/../lib/gcc/x86_64-pc-linux-gnu/6.2.0/../../../../include/c++/6.2.0/cstdlib:124:11: error: reference to 'div_t' is ambiguous
  • /cvmfs/sft.cern.ch/lcg/contrib/gcc/6.2.0native/x86_64-slc6/bin/../lib/gcc/x86_64-pc-linux-gnu/6.2.0/../../../../include/c++/6.2.0/cstdlib:125:11: error: reference to 'ldiv_t' is ambiguous
  • /cvmfs/sft.cern.ch/lcg/contrib/gcc/6.2.0native/x86_64-slc6/bin/../lib/gcc/x86_64-pc-linux-gnu/6.2.0/../../../../include/c++/6.2.0/cstdlib:220:11: error: reference to 'lldiv_t' is ambiguous
  • Error: /mnt/build/jenkins/workspace/root-pullrequests-build/build/bin/rootcling: compilation failure (/mnt/build/jenkins/workspace/root-pullrequests-build/build/lib/libMinuit2087137b452_dictUmbrella.h)

@yamaguchi1024
Copy link
Contributor Author

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

@phsft-bot
Copy link
Collaborator

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on slc6/gcc62.
See console output.

Errors:

  • /usr/include/stdlib.h:785:8: error: reference to 'div_t' is ambiguous
  • /usr/include/stdlib.h:785:14: error: functions that differ only in their return type cannot be overloaded
  • /usr/include/stdlib.h:787:8: error: reference to 'ldiv_t' is ambiguous
  • /usr/include/stdlib.h:787:15: error: functions that differ only in their return type cannot be overloaded
  • /usr/include/stdlib.h:793:22: error: reference to 'lldiv_t' is ambiguous
  • /usr/include/stdlib.h:793:30: error: functions that differ only in their return type cannot be overloaded
  • /cvmfs/sft.cern.ch/lcg/contrib/gcc/6.2.0native/x86_64-slc6/bin/../lib/gcc/x86_64-pc-linux-gnu/6.2.0/../../../../include/c++/6.2.0/cstdlib:124:11: error: reference to 'div_t' is ambiguous
  • /cvmfs/sft.cern.ch/lcg/contrib/gcc/6.2.0native/x86_64-slc6/bin/../lib/gcc/x86_64-pc-linux-gnu/6.2.0/../../../../include/c++/6.2.0/cstdlib:125:11: error: reference to 'ldiv_t' is ambiguous
  • /cvmfs/sft.cern.ch/lcg/contrib/gcc/6.2.0native/x86_64-slc6/bin/../lib/gcc/x86_64-pc-linux-gnu/6.2.0/../../../../include/c++/6.2.0/cstdlib:220:11: error: reference to 'lldiv_t' is ambiguous
  • /cvmfs/sft.cern.ch/lcg/contrib/gcc/6.2.0native/x86_64-slc6/bin/../lib/gcc/x86_64-pc-linux-gnu/6.2.0/../../../../include/c++/6.2.0/stdlib.h:51:12: error: target of using declaration conflicts with declaration already in scope

And 2 more

@yamaguchi1024
Copy link
Contributor Author

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

@phsft-bot
Copy link
Collaborator

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on slc6/gcc62.
See console output.

Failing tests:

And 312 more

@yamaguchi1024
Copy link
Contributor Author

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on

@phsft-bot
Copy link
Collaborator

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on slc6/gcc62.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@yamaguchi1024 yamaguchi1024 changed the title [cxxmodules] [Do not merge] Test for removing excluded tests [cxxmodules] Enable 18 tests and exclude 3 tests May 22, 2018
@phsft-bot
Copy link
Collaborator

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@yamaguchi1024 yamaguchi1024 changed the title [cxxmodules] Enable 18 tests and exclude 3 tests [cxxmodules] Enable 17 tests and exclude 2 tests May 22, 2018
vgvassilev
vgvassilev approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phsft-bot
Copy link
Collaborator

Build failed on slc6/gcc62.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=on
How to customize builds

@yamaguchi1024
[cxxmodules] Enable 17 tests and exclude 3 tests
7bd6688 
Recent change to master fixed some tests which were excluded previously,
       let's enable them again.
@phsft-bot
Copy link
Collaborator

Build failed on slc6/gcc62.
See console output.

Failing tests:

@yamaguchi1024 yamaguchi1024 merged commit 10c22d1 into root-project:master May 22, 2018
@yamaguchi1024 yamaguchi1024 deleted the test_remove_ex branch June 14, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgvassilev vgvassilev vgvassilev approved these changes

@amadio amadio Awaiting requested review from amadio

@pcanal pcanal Awaiting requested review from pcanal

Assignees

@vgvassilev vgvassilev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yamaguchi1024 @phsft-bot @vgvassilev