[RooFit] Add missing 'add' functions to RooArgSet. #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 'add' functions to RooArgSet again, that were removed in 6.06/00.
Problem
This pyROOT code
worked until 6.05/02 (included) and raises an exception since 6.06/00:
Fix
RooArgSet inherits from RooAbsCollection, so it should be possible to add a RootArgSet instance to an other RootArgSet instance via
add()
. This used to work in versions prior to 6.06/00. FromRooArgSet.h in 6.05/02
:This was changed in commit 283f080, where e.g. the above
add
function was replaced byusing RooAbsCollection::add;
However, this only seems to work when the used function is implemented in the base class' header or re-implemented by the inheriting class' which both is not the case. Therefore, I added the functions again to the RooArgSet header.