Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IO] Do not loop over base classes of pair since it is an stl template #3518

Conversation

mrodozov
Copy link

@mrodozov mrodozov commented Mar 8, 2019

Can we get this commit on 6-12 please, it's related to this request:
https://sft.its.cern.ch/jira/projects/ROOT/issues/ROOT-9995?filter=allopenissues
Cheers,
M.

@mrodozov mrodozov requested a review from pcanal as a code owner March 8, 2019 15:54
@phsft-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@pcanal
Copy link
Member

pcanal commented Mar 8, 2019

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-ubuntu16/rtcxxmod, mac1014/cxx17, windows10/default
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on mac1014/cxx17.
See console output.

Errors:

  • FAILED: FREETYPE-prefix/src/FREETYPE-stamp/FREETYPE-configure
  • CMake Error at /build/jenkins/workspace/root-pullrequests-build/build/FREETYPE-prefix/src/FREETYPE-stamp/FREETYPE-configure-Release.cmake:16 (message):

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora27/noimt.
See console output.

Errors:

  • FAILED: DAVIX-prefix/src/DAVIX-stamp/DAVIX-build DAVIX-prefix/lib/libdavix.a DAVIX-prefix/lib/libneon.a DAVIX-prefix/lib/libboost_static_internal.a
  • CMake Error at /mnt/build/workspace/root-pullrequests-build/build/DAVIX-prefix/src/DAVIX-stamp/DAVIX-build-Release.cmake:16 (message):

Warnings:

  • /mnt/build/workspace/root-pullrequests-build/root/core/zip/src/inflate.c:1507:61: warning: left shift of negative value [-Wshift-negative-value]

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-performance-centos7-multicore/default.
See console output.

Errors:

  • collect2: error: ld returned 1 exit status

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu16/rtcxxmod.
See console output.

Errors:

  • FAILED: : && /usr/bin/c++ -fPIC -pipe -m64 -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -fPIC -pthread -std=c++11 -O2 -DNDEBUG -Wl,--no-undefined -shared -Wl,-soname,libASImage.so -o lib/libASImage.so graf2d/asimage/CMakeFiles/ASImage.dir/G__ASImage.cxx.o graf2d/asimage/CMakeFiles/ASImage.dir/src/TASImage.cxx.o graf2d/asimage/CMakeFiles/ASImage.dir/src/TASPluginGS.cxx.o -Wl,-rpath,/mnt/build/workspace/root-pullrequests-build/build/lib: lib/libAfterImage.a /usr/lib/x86_64-linux-gnu/libfreetype.so /usr/lib/x86_64-linux-gnu/libgif.so /usr/lib/x86_64-linux-gnu/libtiff.so /usr/lib/x86_64-linux-gnu/libpng.so -l /usr/lib/x86_64-linux-gnu/libjpeg.so /usr/lib/x86_64-linux-gnu/libSM.so /usr/lib/x86_64-linux-gnu/libICE.so /usr/lib/x86_64-linux-gnu/libX11.so /usr/lib/x86_64-linux-gnu/libXext.so lib/libZLIB.a lib/libGraf.so lib/libHist.so lib/libMatrix.so lib/libMathCore.so lib/libImt.so lib/libRIO.so lib/libThread.so lib/libCore.so && :
  • collect2: error: ld returned 1 exit status

Warnings:

  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module listDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimapDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_multimapDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module setDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_setDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module vectorDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module mapDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module forward_listDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module valarrayDict:

And 7 more

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora29/python3.
See console output.

Errors:

  • FAILED: DAVIX-prefix/src/DAVIX-stamp/DAVIX-build DAVIX-prefix/lib/libdavix.a DAVIX-prefix/lib/libneon.a DAVIX-prefix/lib/libboost_static_internal.a
  • CMake Error at /mnt/build/workspace/root-pullrequests-build/build/DAVIX-prefix/src/DAVIX-stamp/DAVIX-build-Release.cmake:16 (message):

Warnings:

  • /mnt/build/workspace/root-pullrequests-build/root/core/zip/src/inflate.c:1507:61: warning: left shift of negative value [-Wshift-negative-value]

@phsft-bot
Copy link
Collaborator

Build failed on windows10/default.
See console output.

@pcanal
Copy link
Member

pcanal commented Mar 9, 2019

The failures are infrastructure related.

@pcanal pcanal merged commit dc3ae0b into root-project:v6-12-00-patches Mar 9, 2019
@mrodozov mrodozov deleted the cherry-pick-commit-49c731-on-612 branch April 27, 2019 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants