Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ABI compability when linking against OCCI when using clang. #460

Merged
merged 1 commit into from
Mar 28, 2017
Merged

Fix ABI compability when linking against OCCI when using clang. #460

merged 1 commit into from
Mar 28, 2017

Conversation

Teemperor
Copy link
Collaborator

This patch improves the previous check whether the current compiler
is using an incompatible libstdc++ version or not.

@phsft-bot
Copy link
Collaborator

Build started

@vgvassilev
Copy link
Member

@phsft-bot build just on slc6/clang_gcc62 with flags -Dcxxmodules=On -Doracle=On -Dccache=Off -DVc=Off

@phsft-bot
Copy link
Collaborator

Build started

vgvassilev
vgvassilev reviewed Mar 24, 2017
View reviewed changes
sql/oracle/CMakeLists.txt Outdated
# Check if libstdc++ uses the new string ABI and fall back to the old one if yes.
# We have to check for this because on the nightly builds we have an old occi
# installation that uses the old ABI, which results in linking errors.
CHECK_CXX_SOURCE_COMPILES(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it would make more sense to move this check in CheckCompiler.cmake

@phsft-bot
Copy link
Collaborator

Starting build on centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native

@vgvassilev
Copy link
Member

@phsft-bot build also on slc6/clang_gcc62 with flags -Dcxxmodules=On -Doracle=On -Dccache=Off

@phsft-bot
Copy link
Collaborator

Starting build on slc6/clang_gcc62, centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native and CMake flags -Dccache=Off -Dimt=OFF -Dcxxmodules=On -Doracle=On

@Teemperor
Fix ABI compability when linking against OCCI when using clang.
ce7a90f 
This patch improves the previous check whether the current compiler
is using an incompatible libstdc++ version or not.
@vgvassilev
Copy link
Member

@phsft-bot build also on slc6/clang_gcc62 with flags -Dcxxmodules=On -Doracle=On -Dccache=Off

@phsft-bot
Copy link
Collaborator

Starting build on slc6/clang_gcc62, centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native and CMake flags -Dccache=Off -Dimt=OFF -Dcxxmodules=On -Doracle=On

@vgvassilev
Copy link
Member

It seems that the failures are not related to the PR. Merging.

@vgvassilev vgvassilev merged commit 07d6afd into root-project:master Mar 28, 2017
@Teemperor Teemperor deleted the FixOCCILinkingError branch March 28, 2017 13:49
gganis pushed a commit to gganis/root that referenced this pull request Apr 3, 2017
@Teemperor @gganis
Fix ABI compability when linking against OCCI when using clang. (root…
e58e959 
…-project#460)

This patch improves the previous check whether the current compiler
is using an incompatible libstdc++ version or not.
@phsft-bot phsft-bot mentioned this pull request Feb 16, 2018
Merged
@phsft-bot phsft-bot mentioned this pull request Apr 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgvassilev vgvassilev vgvassilev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Teemperor @phsft-bot @vgvassilev