[TTree] Add compression algorithm test for TFile/TTree #5081
Conversation
|
Can one of the admins verify this patch? |
|
@pcanal just FYI, it is a GSOC exersize PR :) |
|
@kamahori Can you add a proper commit message explaining what this code is doing? (it could be helpful https://chris.beams.io/posts/git-commit/) |
|
@phsft-bot build! |
|
Starting build on |
|
Build failed on windows10/cxx14. |
|
How can I see the console output? |
|
@kamahori Jenkins results of tests are not available for people without CERN account, I am sorry for this. Windows failure is not connected with your test, but is actually infrastructure configuration issue (you need to fork https://github.com/root-project/roottest and it will be gone). |
|
@phsft-bot build |
|
@phsft-bot build just on windows10/cxx14 |
|
Starting build on |
|
Sorry, I'm not sure how to remove merge message. |
oshadura
changed the title
oshadura
changed the title
|
@pcanal asked if you can rename file from TTree.cxx to testTTreeCompression.cxx or something similar not to confuse with actual TTree.cxx sources. I will add couple of comments to fix small typos. |
|
Starting build on |
tree/tree/test/TTree.cxx
Outdated
| } | ||
| }; | ||
|
|
||
| TEST_F(TTreeTest, countBaskets) |
There was a problem hiding this comment.
Typo, not "countBaskets", but maybe "testDefaultCompression"
|
Build failed on ROOT-fedora27/noimt. Warnings: |
|
Build failed on ROOT-performance-centos7-multicore/default. Warnings: |
|
Build failed on ROOT-ubuntu16/nortcxxmod. Warnings: |
|
Build failed on ROOT-fedora30/cxx14. Warnings: |
|
Build failed on ROOT-fedora29/python3. Warnings:Failing tests: |
|
Build failed on ROOT-ubuntu18.04-i386/cxx14. Warnings: |
|
Build failed on mac1014/cxx17. Warnings: |
|
@phsft-bot build! |
|
Starting build on |
|
Build failed on ROOT-performance-centos7-multicore/default. Warnings: |
|
Build failed on ROOT-fedora29/python3. Warnings: |
|
Build failed on ROOT-fedora30/cxx14. Warnings: |
|
Build failed on ROOT-ubuntu16/nortcxxmod. Warnings: |
|
Build failed on ROOT-fedora27/noimt. Warnings: |
|
Build failed on ROOT-ubuntu18.04-i386/cxx14. Warnings: |
|
@kamahori no worries about test failures, it is unrelated to your changes |
|
@pcanal can you please review this PR? and give some suggestions how it could be improved extended? |
I added unit test
TTree.cxxwhich checks default compression settings used for TFile.