Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing GL includes in FTGL v6.20 [ROOT-10631] #5199

Merged
merged 1 commit into from Mar 23, 2020
Merged

add missing GL includes in FTGL v6.20 [ROOT-10631] #5199

merged 1 commit into from Mar 23, 2020

Conversation

linev
Copy link
Member

@linev linev commented Mar 23, 2020

No description provided.

@linev linev requested a review from oshadura March 23, 2020 12:09
@linev linev self-assigned this Mar 23, 2020
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14
How to customize builds

@linev linev added the bugfix label Mar 23, 2020
oshadura
oshadura approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@oshadura oshadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@oshadura
Copy link
Contributor

Should it be landing as well in master?

@linev
Copy link
Member Author

linev commented Mar 23, 2020

Should it be landing as well in master?

No, I propose to discuss and merge #5181, where problem solved as well

@oshadura oshadura merged commit 3a7420b into root-project:v6-20-00-patches Mar 23, 2020
@linev linev deleted the v620_glewfix branch March 23, 2020 15:22
@phsft-bot
Copy link
Collaborator

Build failed on mac1014/cxx17.
See console output.

Errors:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshadura oshadura oshadura approved these changes

Assignees

@linev linev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@linev @phsft-bot @oshadura