Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[travis][skip-ci]Remove the exclude clause #5277

Merged
merged 1 commit into from
Apr 2, 2020
Merged

[travis][skip-ci]Remove the exclude clause #5277

merged 1 commit into from
Apr 2, 2020

Conversation

vgvassilev
Copy link
Member

The exclude clause was a workaround travis-ci/travis-ci#4681 but it causes travis-ci/travis-ci#8536 in recent travis.

@vgvassilev vgvassilev requested a review from oshadura April 2, 2020 06:29
hageboeck
hageboeck reviewed Apr 2, 2020
View reviewed changes
Copy link
Member

@hageboeck hageboeck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shallow review: Suggest to remove skip-ci from commit message before merging.

You can also put it in the github description if you want to keep the skipping in place.

@vgvassilev
[travis]Remove the exclude clause
f5781dc 
The exclude clause was a workaround travis-ci/travis-ci#4681 but it causes
travis-ci/travis-ci#8536 in recent travis.
@vgvassilev
Copy link
Member Author

Fair enough. Done.

@vgvassilev vgvassilev merged commit 1e4a782 into root-project:master Apr 2, 2020
@vgvassilev vgvassilev deleted the fix-travis branch April 2, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hageboeck hageboeck hageboeck left review comments

@oshadura oshadura oshadura approved these changes

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann

Assignees

@vgvassilev vgvassilev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vgvassilev @oshadura @hageboeck