Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide correct include dirs for dictionary (ROOT-10658), v 6.20 #5527

Merged
merged 2 commits into from May 13, 2020
Merged

Provide correct include dirs for dictionary (ROOT-10658), v 6.20 #5527

merged 2 commits into from May 13, 2020

Conversation

linev
Copy link
Member

@linev linev commented May 4, 2020

Same patch applied in master within bigger PR #5181

linev added 2 commits May 4, 2020 08:20
@linev
[cmake] set correct list of include dirs for dictionary
d685ee5 
One has to exclude "-I" prefix which was required for direct
command for dicitionarz generation. When compile dictionary,
it has to be removed
@linev
[cmake] add comment what error is fixed
dae9c97
@linev linev requested a review from oshadura May 4, 2020 06:25
@linev linev self-assigned this May 4, 2020
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora29/python3.
Running on root-fedora29-2.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@linev linev added this to the 6.20/04 milestone May 7, 2020
@linev linev added the bugfix label May 7, 2020
@linev linev modified the milestones: 6.20/04, 6.20/06 May 7, 2020
@linev linev merged commit f6f1ea0 into root-project:v6-20-00-patches May 13, 2020
@linev linev deleted the fix_v620_cmake branch May 13, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshadura oshadura oshadura approved these changes

Assignees

@linev linev

Labels
None yet
Projects
None yet
Milestone
6.20/06
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@linev @phsft-bot @oshadura