The roofit/roostats/test/testHypoTestInvResult.cxx test fails on aarch64 and ppc64le #5867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarch64 and ppc64le. This commit adjusts the allowed deviation from the expected value so that the test passes. The reported error is (with slight variations in the exact numbers): /builddir/build/BUILD/root-6.20.06/roofit/roostats/test/testHypoTestInvResult.cxx:24: Failure The difference between result->UpperLimitEstimatedError() and 0.059684301 is 1.1846561807221656e-07, which exceeds 1.E-8, where result->UpperLimitEstimatedError() evaluates to 0.05968418253438193, 0.059684301 evaluates to 0.059684301000000002, and 1.E-8 evaluates to 1e-08.
|
Can one of the admins verify this patch? |
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-performance-centos7-multicore/default. Failing tests:
|
hageboeck
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts the allowed deviation from the expected value so that the test passes.
The reported error is (with slight variations in the exact numbers):
/builddir/build/BUILD/root-6.20.06/roofit/roostats/test/testHypoTestInvResult.cxx:24: Failure
The difference between result->UpperLimitEstimatedError() and 0.059684301 is 1.1846561807221656e-07, which exceeds 1.E-8, where
result->UpperLimitEstimatedError() evaluates to 0.05968418253438193,
0.059684301 evaluates to 0.059684301000000002, and
1.E-8 evaluates to 1e-08.