[ntuple, io] pass paths, names of ntuples for merging to RNTuple side #6101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We construct a vector of string pairs and pass it through to the
RNTuple::Merge function for merging. This implements a "legacy bridge"
between hadd/TFileMerger and the new RNTuple library.
We adhere to the Merge(TCollection*, TFileMergeInfo*) interface without
using either class in the implementation by carefully casting the
RNTuple information vector and output file string pointers.
An example of this technique is shown here, which passes UBSan, ASan,
and strict aliasing checks on gcc 10 and clang 10: https://godbolt.org/z/7ff3e8
For demonstration, the
hadd
output for merging twontuple
files looks like: