Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RS] Skip NaNs and infinities in HypoTestInverter. #6166

Merged
merged 3 commits into from Aug 12, 2020

Conversation

hageboeck
Copy link
Member

If a fit fails, it might produce non-finite confidence levels. This can
be a problem for the hypothesis test inversion.
Here, all non-finite numbers are skipped, in the hope that this can
stabilise a limit calculation in cases where the failed fits are
irrelevant for finding the 95% CL.

If a fit fails, it might produce non-finite confidence levels. This can
be a problem for the hypothesis test inversion.
Here, all non-finite numbers are skipped, in the hope that this can
stabilise a limit calculation in cases where the failed fits are
irrelevant for finding the 95% CL.
@hageboeck hageboeck requested a review from lmoneta August 12, 2020 10:01
@hageboeck hageboeck self-assigned this Aug 12, 2020
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-1.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on mac1014/python3.
Running on macitois21.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

Copy link
Member

@lmoneta lmoneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-1.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on mac1014/python3.
Running on macitois19.cern.ch:/ec/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@hageboeck hageboeck merged commit 398db41 into root-project:master Aug 12, 2020
@hageboeck hageboeck deleted the clsMinusOne branch August 12, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants