New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RS] Skip NaNs and infinities in HypoTestInverter. #6166
Conversation
If a fit fails, it might produce non-finite confidence levels. This can be a problem for the hypothesis test inversion. Here, all non-finite numbers are skipped, in the hope that this can stabilise a limit calculation in cases where the failed fits are irrelevant for finding the 95% CL.
Starting build on |
Build failed on ROOT-fedora30/cxx14. Failing tests: |
Build failed on mac1014/python3. Failing tests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Starting build on |
Build failed on ROOT-fedora30/cxx14. Failing tests: |
Build failed on mac1014/python3. Failing tests: |
If a fit fails, it might produce non-finite confidence levels. This can
be a problem for the hypothesis test inversion.
Here, all non-finite numbers are skipped, in the hope that this can
stabilise a limit calculation in cases where the failed fits are
irrelevant for finding the 95% CL.