Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gmi] Do not load all modules for a given identifier. #6190

Closed

Conversation

vgvassilev
Copy link
Member

This should reduce the amount of modules we load for namespace lookups at the cost of being more fragile.

Improves the memory of hsimple.c from 145864 to 118696 and skips loading of 15 redundant modules.

This should reduce the amount of modules we load for namespace lookups at the
cost of being more fragile.

Improves the memory of hsimple.c from 145864 to 118696 and skips loading of 15
redundant modules.
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on mac1015/cxx17.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-performance-centos7-multicore/default.
Running on olhswep22.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

  • [2020-08-14T10:26:09.808Z] 950/2072 Test TH1 KolmogorovTest infinite loop #705: tutorial-roofit-rf105_funcbinding .................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.94 sec
  • [2020-08-14T10:26:22.542Z] 1052/2072 Test Disabled LogLExecPolicy multithreading testing while bugfixing #809: tutorial-roostats-Zbi_Zgamma ......................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.04 sec
  • [2020-08-14T10:26:43.237Z] 1177/2072 Test [cxxmodules] Unify *32 dictionaries into one #936: tutorial-dataframe-df002_dataModel-py .............................................................***Failed Error regular expression found in output. Regex=[: error:] 1.21 sec

Failing tests:

@pcanal
Copy link
Member

pcanal commented Aug 14, 2020

Out of curiosity what is the symbols that leads to the loading of the 15 spurrious modules in the hsimple case?

@vgvassilev
Copy link
Member Author

Looking up of “ROOT” which is a namespace and is contained across many modules.

@vgvassilev
Copy link
Member Author

This PR is superseded by #10910 where we do the right thing wrt namespace lookups.

@vgvassilev vgvassilev closed this Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants