Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend TCanvasImp interface #622

Merged
merged 4 commits into from
Jun 29, 2017
Merged

Extend TCanvasImp interface #622

merged 4 commits into from
Jun 29, 2017

Conversation

linev
Copy link
Member

@linev linev commented Jun 8, 2017

  • let create TVirtualPadPainter via the TCanvasImp.
  • handling of TCanvas::Update() can be perfromed in TCanvasImp

- let create TVirtualPadPainter via the TCanvasImp.
- handling of TCanvas::Update() can be perfromed in TCanvasImp
@phsft-bot
Copy link
Collaborator

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with CMake flags -Dvc=OFF -Dimt=ON -Dccache=ON

@linev linev requested a review from bellenot June 8, 2017 14:50
@phsft-bot
Copy link
Collaborator

@bellenot
Copy link
Member

bellenot commented Jun 8, 2017

I will merge once the tests are over...

@linev
Copy link
Member Author

linev commented Jun 8, 2017

Usual question - should I reformat original TCanvas code, which I kept as is.

@pcanal
Copy link
Member

pcanal commented Jun 8, 2017

yes in this case, for 'just' the line changed (i.e. the travis recommendation).

@linev
Copy link
Member Author

linev commented Jun 8, 2017

Done

@phsft-bot
Copy link
Collaborator

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with CMake flags -Dvc=OFF -Dimt=ON -Dccache=ON

@linev
Copy link
Member Author

linev commented Jun 8, 2017

yes in this case, for 'just' the line changed (i.e. the travis recommendation).

Philippe, your command does not work for me. I tried:

 git-clang-format --commit 31fb30ff38 --diff --binary `which clang-format`

I do not understand logic behind. Sorry.
@phsft-bot
Copy link
Collaborator

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with CMake flags -Dvc=OFF -Dimt=ON -Dccache=ON

@pcanal
Copy link
Member

pcanal commented Jun 8, 2017

@linev How does it fail?
@vgvassilev Can you help me?

@linev
Copy link
Member Author

linev commented Jun 8, 2017

How does it fail?

It says that there is nothing changed.

@phsft-bot
Copy link
Collaborator

@pcanal
Copy link
Member

pcanal commented Jun 8, 2017

Note: the two failing test (math and cling) are unrelated to this PR.

@phsft-bot
Copy link
Collaborator

@pcanal
Copy link
Member

pcanal commented Jun 9, 2017

@vgvassilev any ideas?

@vgvassilev
Copy link
Member

'projectroot.math.mathcore.test.mathcore_testLogLExecPolicy' should be fixed by #627.
'projectroot.roottest.python.stl.roottest_python_stl_stl' should be fixed by #614.

The other failure I don't know.

fPainter = new TPadPainter;//Do not need plugin manager for this!
else {
if (!UseGL() || fBatch) {
fPainter = !fCanvasImp ? 0 : fCanvasImp->CreatePadPainter();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is

if (fCanvasImp)
  fPainter = fCanvasImp->CreatePadPainter();

maybe a more readable version of this code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a more readable version of this code?

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants