-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend TCanvasImp interface #622
Conversation
linev
commented
Jun 8, 2017
- let create TVirtualPadPainter via the TCanvasImp.
- handling of TCanvas::Update() can be perfromed in TCanvasImp
- let create TVirtualPadPainter via the TCanvasImp. - handling of TCanvas::Update() can be perfromed in TCanvasImp
Starting build on |
Build failed on mac1012/native. Failing tests: |
I will merge once the tests are over... |
Usual question - should I reformat original TCanvas code, which I kept as is. |
yes in this case, for 'just' the line changed (i.e. the travis recommendation). |
Done |
Starting build on |
Philippe, your command does not work for me. I tried:
|
I do not understand logic behind. Sorry.
Starting build on |
@linev How does it fail? |
It says that there is nothing changed. |
Build failed on mac1012/native. Failing tests: |
Note: the two failing test (math and cling) are unrelated to this PR. |
Build failed on slc6/gcc62. Failing tests: |
@vgvassilev any ideas? |
graf2d/gpad/src/TCanvas.cxx
Outdated
fPainter = new TPadPainter;//Do not need plugin manager for this! | ||
else { | ||
if (!UseGL() || fBatch) { | ||
fPainter = !fCanvasImp ? 0 : fCanvasImp->CreatePadPainter(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
if (fCanvasImp)
fPainter = fCanvasImp->CreatePadPainter();
maybe a more readable version of this code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a more readable version of this code?
Done