Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New AddPoint method #6688

Merged
merged 3 commits into from Oct 22, 2020
Merged

New AddPoint method #6688

merged 3 commits into from Oct 22, 2020

Conversation

couet
Copy link
Member

@couet couet commented Oct 22, 2020

Add the method AddPointto TGraph(x,y) and TGraph2D(x,y,z). equivalent to SetPoint(g->GetN(),x,y)and SetPoint(g->GetN(),x,y,z)

@couet couet self-assigned this Oct 22, 2020
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@couet couet requested review from bellenot and removed request for Axel-Naumann October 22, 2020 09:28
bellenot
bellenot approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after minor changes

hist/hist/inc/TGraph.h Outdated Show resolved Hide resolved
hist/hist/inc/TGraph2D.h Outdated Show resolved Hide resolved
@couet @bellenot
Update hist/hist/inc/TGraph.h
8304c2c 
better formatting

Co-authored-by: Bertrand Bellenot <bellenot@users.noreply.github.com>
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@couet @bellenot
Update hist/hist/inc/TGraph2D.h
3428f0b 
Co-authored-by: Bertrand Bellenot <bellenot@users.noreply.github.com>
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@couet couet merged commit da804d6 into root-project:master Oct 22, 2020
@couet couet deleted the addpoint branch October 22, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellenot bellenot bellenot approved these changes

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

Assignees

@couet couet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@couet @phsft-bot @bellenot