TGFileDialog new option to open / save to a folder, instead of a file #7237

ferdymercury · 2021-02-18T01:27:26Z

Solves https://root-forum.cern.ch/t/gui-directory-dialog/17921/

phsft-bot · 2021-02-18T01:27:29Z

Can one of the admins verify this patch?

bellenot · 2021-02-18T07:07:59Z

phsft-bot · 2021-02-18T07:08:06Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-02-18T07:14:06Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-02-18T07:13:33.227Z] /home/sftnight/build/workspace/root-pullrequests-build/root/gui/gui/src/TGFileDialog.cxx:704:65: error: expression cannot be used as a function

phsft-bot · 2021-02-18T07:16:15Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on null:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2021-02-18T07:15:59.615Z] /data/sftnight/workspace/root-pullrequests-build/root/gui/gui/src/TGFileDialog.cxx:704:65: error: expression cannot be used as a function

phsft-bot · 2021-02-18T07:17:02Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-02-18T07:16:43.395Z] FAILED: /usr/bin/ccache /usr/bin/c++ -DVECCORE_ENABLE_VC -I/mnt/build/workspace/root-pullrequests-build/root/gui/gui/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/unix/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/clingutils/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/textinput/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/thread/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/zip/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/rint/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/clib/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/meta/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/gui/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/cont/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/foundation/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/base/inc -Iginclude -I/mnt/build/workspace/root-pullrequests-build/root/graf2d/gpad/inc -I/mnt/build/workspace/root-pullrequests-build/root/hist/hist/inc -I/mnt/build/workspace/root-pullrequests-build/root/math/mathcore/inc -I/mnt/build/workspace/root-pullrequests-build/root/math/mathcore/v7/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/imt/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/multiproc/inc -Iexternals/mnt/build/workspace/root-pullrequests-build/install/include -I/mnt/build/workspace/root-pullrequests-build/root/math/matrix/inc -I/mnt/build/workspace/root-pullrequests-build/root/graf2d/graf/inc -I/mnt/build/workspace/root-pullrequests-build/root/io/io/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/clib/res -I/mnt/build/workspace/root-pullrequests-build/root/builtins -I/usr/include/freetype2 -I/usr/include/x86_64-linux-gnu/freetype2 -I/mnt/build/workspace/root-pullrequests-build/root/gui/ged/inc -I/mnt/build/workspace/root-pullrequests-build/root/net/net/inc -fdiagnostics-color=always -std=c++11 -pipe -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -pthread -O3 -fPIC -std=c++11 -MD -MT gui/gui/CMakeFiles/Gui.dir/src/TGFileDialog.cxx.o -MF gui/gui/CMakeFiles/Gui.dir/src/TGFileDialog.cxx.o.d -o gui/gui/CMakeFiles/Gui.dir/src/TGFileDialog.cxx.o -c /mnt/build/workspace/root-pullrequests-build/root/gui/gui/src/TGFileDialog.cxx
[2021-02-18T07:16:43.395Z] /mnt/build/workspace/root-pullrequests-build/root/gui/gui/src/TGFileDialog.cxx:704:65: error: expression cannot be used as a function

phsft-bot · 2021-02-18T07:20:32Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-02-18T07:20:26.526Z] FAILED: gui/gui/CMakeFiles/Gui.dir/src/TGFileDialog.cxx.o
[2021-02-18T07:20:28.516Z] /home/sftnight/build/workspace/root-pullrequests-build/root/gui/gui/src/TGFileDialog.cxx:704:65: error: expression cannot be used as a function

phsft-bot · 2021-02-18T07:22:42Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-02-18T07:21:47.948Z] FAILED: gui/gui/CMakeFiles/Gui.dir/src/TGFileDialog.cxx.o
[2021-02-18T07:21:49.241Z] /home/sftnight/build/workspace/root-pullrequests-build/root/gui/gui/src/TGFileDialog.cxx:704:65: error: expression cannot be used as a function

phsft-bot · 2021-02-18T07:26:28Z

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-02-18T07:26:20.301Z] FAILED: gui/gui/CMakeFiles/Gui.dir/src/TGFileDialog.cxx.o
[2021-02-18T07:26:20.875Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/gui/gui/src/TGFileDialog.cxx:704:27: error: called object type 'TGCheckButton *' is not a function or function pointer

phsft-bot · 2021-02-18T07:40:51Z

Build failed on mac1014/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-02-18T07:40:43.137Z] FAILED: gui/gui/CMakeFiles/Gui.dir/src/TGFileDialog.cxx.o
[2021-02-18T07:40:44.076Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/gui/gui/src/TGFileDialog.cxx:704:27: error: called object type 'TGCheckButton *' is not a function or function pointer

phsft-bot · 2021-02-18T07:43:49Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2021-02-18T07:37:49.142Z] C:\build\workspace\root-pullrequests-build\root\gui\gui\src\TGFileDialog.cxx(703,64): error C2064: term does not evaluate to a function taking 1 arguments [C:\build\workspace\root-pullrequests-build\build\gui\gui\Gui.vcxproj]

bellenot · 2021-02-18T08:42:16Z

@phsft-bot build

phsft-bot · 2021-02-18T08:42:24Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-02-18T09:46:35Z

Build failed on mac11.0/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.tree.ntuple.v7.test.gtest_tree_ntuple_v7_test_ntuple_extended

phsft-bot · 2021-02-18T10:55:49Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

bellenot · 2021-02-18T12:44:39Z

I'll have to try it before to review, but before that, may I ask what is the real use case? We only had one question on the forum so far, with an alternative solution...

ferdymercury · 2021-02-18T13:04:38Z

There were two more forum posts also:
https://root-forum.cern.ch/t/select-directory-with-tgfiledialog/20481
https://root-forum.cern.ch/t/set-up-working-directory/2528

The alternative solution involves defining extra derived classes, etc, which is a bit of a burden.

Selecting a folder is useful, for example when you save all open canvases as .png files. You want to select a output folder, and then the script does: for(auto c: gROOT->GetListOfCanvases()) c->SaveAs(outputFolder + "/" + c->GetName()+".png");
Another example is when want to store all DICOM files of a CT scan that you are simulating. The result is always splitted in N files, one per slice, not a single file. Thus it only makes sense to have a TGFileDialog that allows you to select a directory, not a file.

I think this functionality is generic enough to be used by more users. In fact, QtFileDialog has exactly this kind of property:

QFileDialog dialog;
dialog.setFileMode(QFileDialog::DirectoryOnly);
dialog.setOption(QFileDialog::ShowDirsOnly, false);

See https://forum.qt.io/topic/62138/qfiledialog-choose-directories-only-but-show-files-as-well/13

bellenot · 2021-02-18T13:07:34Z

OK, thanks. I'll take care of it as soon as I can

gui/gui/inc/TGFileDialog.h

gui/gui/src/TGFileDialog.cxx

ferdymercury · 2021-02-23T14:34:15Z

Thanks for the feedback. I think I fixed them now.

gui/gui/src/TGFileDialog.cxx

Co-authored-by: Bertrand Bellenot <bellenot@users.noreply.github.com>

gui/gui/src/TGFileDialog.cxx

Co-authored-by: Bertrand Bellenot <bellenot@users.noreply.github.com>

bellenot · 2021-02-25T08:11:48Z

@phsft-bot build

phsft-bot · 2021-02-25T08:11:54Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-02-25T09:24:17Z

Build failed on mac11.0/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.io.compression.roottest_root_io_compression_make

phsft-bot · 2021-02-25T10:09:33Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

bellenot · 2021-02-25T12:14:33Z

@ferdymercury Thanks for this contribution! Test failures are unrelated, so let's merge

bellenot

Thanks for the nice improvement!

…root-project#7237) * add directory selection as one dialog mode * implement folder dialog type * add extra security to prevent nullptr access * fix typo in last commit * redundant check to make clang tidy analyzer happy * correctly handle double-click, and disable button if file is selected * fix directory name when double click * align member * follow coding conventions * split two lines to avoid long lines Co-authored-by: Bertrand Bellenot <bellenot@users.noreply.github.com> * avoid long lines, split * simplify if clauses Co-authored-by: Bertrand Bellenot <bellenot@users.noreply.github.com> Co-authored-by: Bertrand Bellenot <bellenot@users.noreply.github.com>

ferdymercury added 2 commits February 17, 2021 19:27

add directory selection as one dialog mode

c8f8cf3

implement folder dialog type

30c7c09

ferdymercury requested a review from bellenot as a code owner February 18, 2021 01:27

add extra security to prevent nullptr access

38a0241

bellenot self-assigned this Feb 18, 2021

fix typo in last commit

b18a123

redundant check to make clang tidy analyzer happy

14577f3

ferdymercury added 2 commits February 18, 2021 15:56

correctly handle double-click, and disable button if file is selected

b2948b9

fix directory name when double click

0a79886

bellenot requested changes Feb 23, 2021

View reviewed changes

ferdymercury added 2 commits February 23, 2021 15:26

align member

a52b5ea

follow coding conventions

14acfcf

ferdymercury requested a review from bellenot February 23, 2021 14:34

bellenot requested changes Feb 24, 2021

View reviewed changes

gui/gui/src/TGFileDialog.cxx Outdated Show resolved Hide resolved

gui/gui/src/TGFileDialog.cxx Outdated Show resolved Hide resolved

ferdymercury and others added 2 commits February 24, 2021 17:44

split two lines to avoid long lines

289e89c

Co-authored-by: Bertrand Bellenot <bellenot@users.noreply.github.com>

avoid long lines, split

0baea2c

ferdymercury requested a review from bellenot February 24, 2021 16:47

bellenot requested changes Feb 24, 2021

View reviewed changes

gui/gui/src/TGFileDialog.cxx Outdated Show resolved Hide resolved

simplify if clauses

ed484cd

Co-authored-by: Bertrand Bellenot <bellenot@users.noreply.github.com>

ferdymercury requested a review from bellenot February 24, 2021 17:01

bellenot added affects:master improvement in:GUI labels Feb 25, 2021

bellenot approved these changes Feb 25, 2021

View reviewed changes

bellenot merged commit 59b234c into root-project:master Feb 25, 2021

ferdymercury deleted the patch-4 branch February 25, 2021 12:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TGFileDialog new option to open / save to a folder, instead of a file #7237

TGFileDialog new option to open / save to a folder, instead of a file #7237

ferdymercury commented Feb 18, 2021 •

edited

phsft-bot commented Feb 18, 2021

bellenot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

bellenot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

bellenot commented Feb 18, 2021

ferdymercury commented Feb 18, 2021 •

edited

bellenot commented Feb 18, 2021

ferdymercury commented Feb 23, 2021

bellenot commented Feb 25, 2021

phsft-bot commented Feb 25, 2021

phsft-bot commented Feb 25, 2021

phsft-bot commented Feb 25, 2021

bellenot commented Feb 25, 2021

bellenot left a comment

TGFileDialog new option to open / save to a folder, instead of a file #7237

TGFileDialog new option to open / save to a folder, instead of a file #7237

Conversation

ferdymercury commented Feb 18, 2021 • edited

phsft-bot commented Feb 18, 2021

bellenot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

Errors:

phsft-bot commented Feb 18, 2021

Errors:

phsft-bot commented Feb 18, 2021

Errors:

phsft-bot commented Feb 18, 2021

Errors:

phsft-bot commented Feb 18, 2021

Errors:

phsft-bot commented Feb 18, 2021

Errors:

phsft-bot commented Feb 18, 2021

Errors:

phsft-bot commented Feb 18, 2021

Errors:

bellenot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

phsft-bot commented Feb 18, 2021

Failing tests:

phsft-bot commented Feb 18, 2021

Failing tests:

bellenot commented Feb 18, 2021

ferdymercury commented Feb 18, 2021 • edited

bellenot commented Feb 18, 2021

ferdymercury commented Feb 23, 2021

bellenot commented Feb 25, 2021

phsft-bot commented Feb 25, 2021

phsft-bot commented Feb 25, 2021

Failing tests:

phsft-bot commented Feb 25, 2021

Failing tests:

bellenot commented Feb 25, 2021

bellenot left a comment

Choose a reason for hiding this comment

ferdymercury commented Feb 18, 2021 •

edited

ferdymercury commented Feb 18, 2021 •

edited