Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thread-safe gSystem list of timers #8562

Merged
merged 4 commits into from Jun 29, 2021
Merged

thread-safe gSystem list of timers #8562

merged 4 commits into from Jun 29, 2021

Conversation

ferdymercury
Copy link
Collaborator

This Pull request:

Changes or fixes:

Makes the list of timers thread-safe.
It attempts to fix some of the issues reported in #8365

This is a follow-up from: #8379 (comment)

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@phsft-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@pcanal
Copy link
Member

pcanal commented Jun 29, 2021

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-06-29T01:30:41.100Z] FAILED: core/thread/CMakeFiles/Thread.dir/src/TPosixThread.cxx.o
  • [2021-06-29T01:30:41.509Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/core/thread/src/TPosixThread.cxx:41:7: error: unknown type name 'cpu_set_t'
  • [2021-06-29T01:30:41.509Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/core/thread/src/TPosixThread.cxx:44:48: error: use of undeclared identifier 'cpu_set_t'; did you mean 'cpuset'?

@phsft-bot
Copy link
Collaborator

Build failed on mac1014/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-06-29T02:16:40.351Z] FAILED: core/thread/CMakeFiles/Thread.dir/src/TPosixThread.cxx.o
  • [2021-06-29T02:16:40.610Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/core/thread/src/TPosixThread.cxx:41:7: error: unknown type name 'cpu_set_t'
  • [2021-06-29T02:16:40.610Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/core/thread/src/TPosixThread.cxx:44:48: error: use of undeclared identifier 'cpu_set_t'; did you mean 'cpuset'?

@pcanal
Copy link
Member

pcanal commented Jun 29, 2021

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@pcanal
Copy link
Member

pcanal commented Jun 29, 2021

As reported at #8564 (comment), "The Debian i686 errors are due to a node upgrade".

@pcanal pcanal merged commit 8f93e6d into root-project:master Jun 29, 2021
@pcanal
Copy link
Member

pcanal commented Jun 29, 2021

thanks

@ferdymercury ferdymercury deleted the patch-14 branch June 29, 2021 22:46
@ferdymercury ferdymercury mentioned this pull request Jun 30, 2021
Open
1 task
AdvaitDhingra pushed a commit to AdvaitDhingra/root that referenced this pull request Jul 5, 2021
@ferdymercury @AdvaitDhingra
thread-safe gSystem list of timers (root-project#8562)
9d3971e 
Convert list of timers to TList to make it thread-safe

Make list of timers thread-safe
   as suggested by pcanal on root-project#8379 (comment)
AdvaitDhingra pushed a commit to AdvaitDhingra/root that referenced this pull request Jul 5, 2021
@ferdymercury @AdvaitDhingra
thread-safe gSystem list of timers (root-project#8562)
a88ca03 
Convert list of timers to TList to make it thread-safe

Make list of timers thread-safe
   as suggested by pcanal on root-project#8379 (comment)
pzhristov pushed a commit to alisw/root that referenced this pull request Aug 27, 2021
@ferdymercury
thread-safe gSystem list of timers (root-project#8562)
c8acb66 
Convert list of timers to TList to make it thread-safe

Make list of timers thread-safe
   as suggested by pcanal on root-project#8379 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcanal pcanal pcanal approved these changes

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann

Assignees

@Axel-Naumann Axel-Naumann

@pcanal pcanal

Labels
in:Core Libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ferdymercury @phsft-bot @pcanal @Axel-Naumann @bellenot