[tcling] Disable runtime resolution for identifiers that are certainly types #9160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given two consecutive identifiers, the first token is necessarily a type name, e.g. in `foo bar`, `foo` is certainly a type. In this case, runtime resolution must be disabled. More details here: https://sft.its.cern.ch/jira/browse/ROOT-5268 Closes JIRA issue ROOT-5268.
|
Starting build on |
|
Build failed on ROOT-debian10-i386/cxx14. Errors:
|
|
Build failed on mac11.0/cxx17. Failing tests: |
|
Build failed on mac1014/python3. Failing tests: |
|
@phsft-bot build just on mac1014/python3 |
|
Starting build on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given two consecutive identifiers, the first token is necessarily a type name, e.g. in
foo bar,foois a type. This pull-request disables runtime resolution for this case.Previously, the lookup was returning a VarDecl of type
DependentTyregardless of the identifier being probably a mistyped type. This caused clang to start parsing an expression, which ended up in misleading diagnostic messages.More details here: https://sft.its.cern.ch/jira/browse/ROOT-5268
Sibling PR in roottest: root-project/roottest#786.
Changes or fixes:
Checklist:
This PR fixes JIRA issue ROOT-5268.