Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DF] Add test for Fill with object with arbitrary signature #9495

Merged
merged 1 commit into from Jan 7, 2022
Merged

[DF] Add test for Fill with object with arbitrary signature #9495

merged 1 commit into from Jan 7, 2022

Conversation

eguiraud
Copy link
Member

@eguiraud eguiraud commented Jan 5, 2022

This is the last piece missing to fix #9428.

@eguiraud eguiraud self-assigned this Jan 5, 2022
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-01-05T12:38:21.489Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1064 (message):

@eguiraud eguiraud mentioned this pull request Jan 5, 2022
Merged
@phsft-bot
Copy link
Collaborator

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

  • [2022-01-05T14:01:54.193Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/TBufferMerger.hxx:218:21: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-01-05T14:01:54.193Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/TBufferMerger.hxx:221:4: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-01-05T14:01:57.915Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/io/io/inc/ROOT/TBufferMerger.hxx:218:21: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-01-05T14:01:57.916Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/io/io/inc/ROOT/TBufferMerger.hxx:221:4: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-01-05T14:01:58.431Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/io/io/inc/ROOT/TBufferMerger.hxx:218:21: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-01-05T14:01:58.431Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/io/io/inc/ROOT/TBufferMerger.hxx:221:4: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-01-05T14:02:04.477Z] include/ROOT/TBufferMerger.hxx:218:21: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-01-05T14:02:04.477Z] include/ROOT/TBufferMerger.hxx:221:4: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-01-05T14:02:32.743Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RVec.hxx:180:4: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-01-05T14:02:32.743Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RVec.hxx:883:4: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]

And 433 more

Failing tests:

Axel-Naumann
Axel-Naumann approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@Axel-Naumann Axel-Naumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But see comment.

tree/dataframe/test/dataframe_interface.cxx Outdated Show resolved Hide resolved
tree/dataframe/test/dataframe_interface.cxx Show resolved Hide resolved
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@eguiraud eguiraud merged commit adea11c into root-project:master Jan 7, 2022
@eguiraud eguiraud deleted the df-fill-test branch January 7, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Axel-Naumann Axel-Naumann Axel-Naumann approved these changes

Assignees

@eguiraud eguiraud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DF] Fill method does not support arbitrary signatures
3 participants
@eguiraud @phsft-bot @Axel-Naumann