[RF] Remove RooFit banner from reference files

[henryiii]

Matching root-project/root#9999 - backport of #834.

[phsft-bot]

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

[phsft-bot]

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Errors:

• [2022-03-01T14:55:38.664Z] FAILED: builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download /Users/sftnight/build/workspace/roottest-pullrequests-build/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download
• [2022-03-01T14:55:38.664Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):

[phsft-bot]

Build failed on mac1015/python3.
Running on macitois19.dyndns.cern.ch:/Users/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

• projectroot.roottest.python.distrdf.common.roottest_python_distrdf_common_common_test_rungraphs

[phsft-bot]

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\roottest-pullrequests-build
See console output.

Failing tests:

• projectroot.tree.dataframe.test.gtest_tree_dataframe_test_dataframe_vary

[matthewfeickert]

@guitargeek, as this missed release 6.26/02 can this get reviewed again so that root-project/root#9999 can go it for the next patch release?

[henryiii]

Poke me if anything need to be done, I was under the impression it was ready.

[guitargeek]

Hi, thanks for the ping!

Sorry for coming back to this so late. I forgot to let you know that it was decided that the banner removal will not be done in the 6.26 branch. So unfortunately, I have to close this PR.

At least in the upcoming 6.26 release, the banner is gone for good! I hope this compromise is acceptable for you.

[matthewfeickert]

I forgot to let you know that it was decided that the banner removal will not be done in the 6.26 branch. So unfortunately, I have to close this PR.

Thanks for this information. Out of curiosity, is the discussion for the decision to wait till release 6.28 public?

[guitargeek]

Hi! No the discussion was not public. The main argument is that patch releases are only for bugfixes, not to introduce behavior change. By removing the RooFit banner, we might cause hickups in user workflows just like here in roottests if people compare their logs to reference files. That should not happen in a patch release

[matthewfeickert]

Thanks for clarifying. This is what I assumed. I'm not going to argue as you have more relevant things to do and you've already helped a lot in just getting this in (thank you for that!), but testing frameworks are not users and users should be using APIs not banners to extract information. While I appreciate that ROOT might want to be better about following SemVer then it has been in the past, it is hard to see this as a breaking change (but maybe it is sadly).