NodePort API spec & socat implementation #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
force-pushed
the
wip
branch
9 times, most recently
from
6e36ccb
to
67d6269
Compare
AkihiroSuda
changed the title
Closed
AkihiroSuda
commented
Oct 24, 2018
pkg/api/client/client.go
Outdated
| return b, err | ||
| } | ||
| if lr.N == 0 { | ||
| return b, errors.Errorf("expected at most %d bytes, got more (%d bytes are still left)", maxBytes, lr.N) |
There was a problem hiding this comment.
TODO: fix error string
AkihiroSuda
force-pushed
the
wip
branch
2 times, most recently
from
08a9a0a
to
c44b84b
Compare
The API can be used for exposing TCP/UDP ports in the network namespace created along with the user namespace to the host network namespace. * `api.sock` is created under the `rootlesskit --state-dir` directory * API is described in `pkg/api/openapi.yaml` * `GET /v1/ports` * `POST /v1/ports` * `DELETE /v1/ports` * `rootlessctl` CLI can be used as an API client: * `rootlessctl list-ports` * `rootlessctl add-ports` * `rootlessctl remove-ports` * To expose child 80 as parent 8080: `rootlessctl --socket=/path/to/api.sock add-ports 0.0.0.0:8080:80/tcp` Currently, only `socat` implementation is available as `rootlesskit --port-driver`. The code under `pkg/port/socat` package might be also reusable for other projects. Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
|
slirp4netns mtu=65520
not so bad |
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API can be used for exposing TCP/UDP ports in the network namespace created along with the user namespace to the host network namespace.
api.sockis created under therootlesskit --state-dirdirectorypkg/api/openapi.yamlGET /v1/portsPOST /v1/portsDELETE /v1/portsrootlessctlCLI can be used as an API client:rootlessctl list-portsrootlessctl add-portsrootlessctl remove-portsrootlessctl --socket=/path/to/api.sock add-ports 0.0.0.0:8080:80/tcpCurrently, only
socatimplementation is available asrootlesskit --port-driver.The
slirp4netns-native implementation is being experimented at rootless-containers/slirp4netns#29 but it does not work with large MTUs at the moment.The code under
pkg/port/socatpackage might be also reusable for other projects.Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp