Remove duplicate id ranges returned by getsubu/gid for username/uid #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-do-cpp
force-pushed
the
fix-dynid-duplicate-ranges
branch
from
bbc1b27
to
da8db9a
Compare
AkihiroSuda
reviewed
May 29, 2023
pkg/parent/dynidtools/dynidtools.go
Outdated
| @@ -14,6 +14,18 @@ import ( | |||
| "github.com/sirupsen/logrus" | |||
| ) | |||
|
|
|||
| func withoutDuplicates[T idtools.SubIDRange](sliceList []T) []T { | |||
Signed-off-by: i-do-cpp <62053234+i-do-cpp@users.noreply.github.com>
i-do-cpp
force-pushed
the
fix-dynid-duplicate-ranges
branch
from
da8db9a
to
15e2415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LDAP-based environments both
getsubids myusernameandgetsubids 1234(whereid myusernameequals to1234) can return exactly the same subuid ranges. This happens when one of/etc/subuidornssreturns mappings for both the user id and the user name. Bothnewgidmapandnewuidmapfail when the parameters contain duplicate ranges.This PR fixes the problem by removing duplicates from the list of subid mappings in
dynidtools.idtools(/etc/subuidhandling) is left untouched.