vendor: update libslirp #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
AkihiroSuda
reviewed
Nov 21, 2019
vendor.sh
Outdated
| @@ -1,7 +1,7 @@ | |||
| #!/bin/bash | |||
| set -eux -o pipefail | |||
| # Aug 26, 2019 | |||
There was a problem hiding this comment.
please update date, then LGTM
|
thanks, do you want to backport this to the v0.3 branch? |
update to libslirp d171af3732a0610a25334b06b77fa547bd677918 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
update-libslirp
branch
from
7a2504c
to
9e9c0ae
Compare
we can just cut a new minor release, and in Fedora/RHEL we'll use it |
AkihiroSuda
approved these changes
Nov 21, 2019
|
thanks for the quick review! Could we cut a new release? |
|
Let's cut a new release after libslirp v4.1.0 gets released: https://gitlab.freedesktop.org/slirp/libslirp/merge_requests/21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to libslirp d171af3732a0610a25334b06b77fa547bd677918
I need it for https://gitlab.freedesktop.org/slirp/libslirp/merge_requests/19
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com