Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] helper for comparing histograms #330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schmitts
Copy link
Member

I've added a helper class to compare "stuff" and a concrete implementation for comparing histograms, as well as an example. The expected output is attached. I'm aware that it needs some work, but before I go into polishing I'd like to discuss if you find it helpful in the first place.

compare

@pwaller
Copy link
Member

pwaller commented Jun 13, 2013

This looks pretty great. I note that the branch is called WIP_compare, is there anything which is waiting?

@ndawe
Copy link
Member

ndawe commented Jun 13, 2013

Yeah, thanks for this extremely useful feature! I'll review.

@@ -0,0 +1,29 @@
import ROOT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add the doc text here like the other examples and print __doc__. This is used in the automatic documentation generation.

@schmitts
Copy link
Member Author

This looks pretty great. I note that the branch is called WIP_compare, is there anything which is waiting?

Documentation for sure. Feature wise I'm not sure. I'm migrating my
plotting scripts at the moment, so whenever I hit a feature that's not
in yet, I'll add it.

@schmitts
Copy link
Member Author

I made some changes to the implementation. I couldn't put it in plottings.utils because of circular dependencies when import Legend.

@ndawe
Copy link
Member

ndawe commented Sep 23, 2013

What about separating this PR into two components: one part in a new module plotting.layout that could contain a highly configurable RatioPlot class (and more to come in the future) and then a separate module plotting.compare that would make use of RatioPlot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants